Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: third_party/zlib/BUILD.gn

Issue 1226583002: clang/win: Build chromium code without -Wno-incompatible-pointer-types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@clang-logical-op-parentheses
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/zlib/BUILD.gn
diff --git a/third_party/zlib/BUILD.gn b/third_party/zlib/BUILD.gn
index a1317f222908687b218ae7724bd6a4677669b79e..0d592189c8b1811dd565f946fb1901ac6dbe548b 100644
--- a/third_party/zlib/BUILD.gn
+++ b/third_party/zlib/BUILD.gn
@@ -67,6 +67,13 @@ static_library("zlib") {
if (!is_ios && (current_cpu == "x86" || current_cpu == "x64")) {
sources += [ "x86.c" ]
+
+ config("zlib_warnings") {
+ if (is_clang) {
+ cflags = [ "-Wno-incompatible-pointer-types" ]
+ }
+ }
+ configs += [ ":zlib_warnings" ]
}
configs -= [ "//build/config/compiler:chromium_code" ]

Powered by Google App Engine
This is Rietveld 408576698