Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3152)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1226583002: clang/win: Build chromium code without -Wno-incompatible-pointer-types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@clang-logical-op-parentheses
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 8d6acec8a9edd10c33f4874e8999ff91c02c2d6c..68cf03b3e8bd3d232da6ed245276f36527f16fb3 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -800,7 +800,6 @@ if (is_win) {
# TODO(hans): Make this list shorter eventually, http://crbug.com/504657
"-Qunused-arguments", # http://crbug.com/504658
"-Wno-extra-tokens", # http://crbug.com/504663
- "-Wno-incompatible-pointer-types", # http://crbug.com/504696
"-Wno-microsoft", # http://crbug.com/505296
"-Wno-missing-braces", # http://crbug.com/505297
"-Wno-pointer-sign", # http://crbug.com/505303

Powered by Google App Engine
This is Rietveld 408576698