Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: third_party/zlib/zlib.gyp

Issue 1226583002: clang/win: Build chromium code without -Wno-incompatible-pointer-types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@clang-logical-op-parentheses
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« third_party/libwebp/libwebp.gyp ('K') | « third_party/zlib/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 'target_name' : 'zlib_x86_simd', 8 'target_name' : 'zlib_x86_simd',
9 'type': 'static_library', 9 'type': 'static_library',
10 'conditions': [ 10 'conditions': [
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 '.', 74 '.',
75 ], 75 ],
76 'direct_dependent_settings': { 76 'direct_dependent_settings': {
77 'include_dirs': [ 77 'include_dirs': [
78 '.', 78 '.',
79 ], 79 ],
80 }, 80 },
81 'conditions': [ 81 'conditions': [
82 ['OS!="ios" and (target_arch=="ia32" or target_arch=="x64")', { 82 ['OS!="ios" and (target_arch=="ia32" or target_arch=="x64")', {
83 'sources' : [ 'x86.c', ], 83 'sources' : [ 'x86.c', ],
84 'variables': {
85 'clang_warning_flags': [
86 '-Wno-incompatible-pointer-types',
fbarchard 2015/07/10 19:26:42 Does this option not work on arm/mips?
Nico 2015/07/10 19:28:38 It should work everywhere where we use chromium's
Sam McNally 2015/07/13 08:00:26 This is disabling a warning that is only triggered
87 ],
88 },
84 }], 89 }],
85 ['OS!="win"', { 90 ['OS!="win"', {
86 'product_name': 'chrome_zlib', 91 'product_name': 'chrome_zlib',
87 }], ['OS=="android"', { 92 }], ['OS=="android"', {
88 'toolsets': ['target', 'host'], 93 'toolsets': ['target', 'host'],
89 }], 94 }],
90 ], 95 ],
91 }, 96 },
92 { 97 {
93 'target_name': 'minizip', 98 'target_name': 'minizip',
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 # fseeko64. We use fopen, ftell, and fseek instead on these 139 # fseeko64. We use fopen, ftell, and fseek instead on these
135 # systems. 140 # systems.
136 'defines': [ 141 'defines': [
137 'USE_FILE32API' 142 'USE_FILE32API'
138 ], 143 ],
139 }], 144 }],
140 ], 145 ],
141 }, 146 },
142 ], 147 ],
143 } 148 }
OLDNEW
« third_party/libwebp/libwebp.gyp ('K') | « third_party/zlib/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698