Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Side by Side Diff: third_party/iaccessible2/BUILD.gn

Issue 1226583002: clang/win: Build chromium code without -Wno-incompatible-pointer-types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@clang-logical-op-parentheses
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 assert(is_win) 5 assert(is_win)
6 6
7 import("//build/toolchain/win/midl.gni") 7 import("//build/toolchain/win/midl.gni")
8 8
9 midl("iaccessible2") { 9 midl("iaccessible2") {
10 sources = [ 10 sources = [
11 "ia2_api_all.idl", 11 "ia2_api_all.idl",
12 ] 12 ]
13 } 13 }
14 14
15 # Generate a proxy DLL from the generated code. 15 # Generate a proxy DLL from the generated code.
16 shared_library("IAccessible2Proxy") { 16 shared_library("IAccessible2Proxy") {
17 sources = [ 17 sources = [
18 "$target_gen_dir/ia2_api_all.dlldata.c", 18 "$target_gen_dir/ia2_api_all.dlldata.c",
19 "$target_gen_dir/ia2_api_all_p.c", 19 "$target_gen_dir/ia2_api_all_p.c",
20 "IAccessible2Proxy.def", 20 "IAccessible2Proxy.def",
21 ] 21 ]
22 22
23 config("IAccessible2Proxy_warnings") { 23 config("IAccessible2Proxy_warnings") {
24 if (is_clang) { 24 if (is_clang) {
25 # MIDL generated code has a habit of omitting optional braces. 25 cflags = [
26 cflags = [ "-Wno-missing-braces" ] 26 # MIDL generated code has a habit of omitting optional braces.
27 "-Wno-missing-braces",
28 "-Wno-incompatible-pointer-types",
29 ]
27 } 30 }
28 } 31 }
29 configs -= [ "//build/config/compiler:chromium_code" ] 32 configs -= [ "//build/config/compiler:chromium_code" ]
30 configs += [ "//build/config/compiler:no_chromium_code" ] 33 configs += [ "//build/config/compiler:no_chromium_code" ]
31 configs += [ ":IAccessible2Proxy_warnings" ] 34 configs += [ ":IAccessible2Proxy_warnings" ]
32 35
33 defines = [ "REGISTER_PROXY_DLL" ] 36 defines = [ "REGISTER_PROXY_DLL" ]
34 37
35 libs = [ "rpcrt4.lib" ] 38 libs = [ "rpcrt4.lib" ]
36 39
37 deps = [ 40 deps = [
38 ":iaccessible2", 41 ":iaccessible2",
39 ] 42 ]
40 } 43 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698