Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1226563002: Revert of Revert of [1b] Implement FetchBlobDataConsumerHandle (Closed)

Created:
5 years, 5 months ago by dcheng
Modified:
5 years, 5 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Revert of [1b] Implement FetchBlobDataConsumerHandle (patchset #1 id:1 of https://codereview.chromium.org/1207273003/) Reason for revert: Relanding. Original issue's description: > Revert of [1b] Implement FetchBlobDataConsumerHandle (patchset #18 id:320001 of https://codereview.chromium.org/1176403006/) > > Reason for revert: > May have broken IndexedDBBrowserTestWithGCExposed.BlobDidAck. > > Original issue's description: > > Implement FetchBlobDataConsumerHandle > > > > Unit tests will be added in https://codereview.chromium.org/1199043004/. > > > > FetchInitiatorTypeNames.in is modified to use FetchInitiatorTypeNames::internal from modules/. > > > > BUG=480746 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198220 > > TBR=haraken@chromium.org,mkwst@chromium.org,oilpan-reviews@chromium.org,yhirano@chromium.org,hiroshige@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=480746 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198229 TBR=haraken@chromium.org,mkwst@chromium.org,oilpan-reviews@chromium.org,yhirano@chromium.org,hiroshige@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=480746 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198237

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+530 lines, -0 lines) Patch
M Source/core/fetch/FetchInitiatorTypeNames.in View 1 chunk +1 line, -0 lines 0 comments Download
A Source/modules/fetch/FetchBlobDataConsumerHandle.h View 1 chunk +47 lines, -0 lines 0 comments Download
A Source/modules/fetch/FetchBlobDataConsumerHandle.cpp View 1 chunk +480 lines, -0 lines 0 comments Download
M Source/modules/modules.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcheng
Created Revert of Revert of [1b] Implement FetchBlobDataConsumerHandle
5 years, 5 months ago (2015-07-02 18:20:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226563002/1
5 years, 5 months ago (2015-07-02 18:20:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=198237
5 years, 5 months ago (2015-07-02 18:21:06 UTC) #3
haraken
5 years, 5 months ago (2015-07-02 22:05:53 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698