chrome/browser/prefs/pref_hash_store.h - Issue 122653005: Chrome Settings Hardening

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/pref_hash_store.h

Issue 122653005: Chrome Settings Hardening (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: void* 0xBAD instead of returning a base::Value* in checked/stored_value() test helper Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/prefs/pref_hash_store.h

diff --git a/chrome/browser/prefs/pref_hash_store.h b/chrome/browser/prefs/pref_hash_store.h

index ebef8c0b2bceba521a763fc6a0e75ea3d2ec893e..12449452b00bae8e94cef773e1a93d855fd038f3 100644

--- a/chrome/browser/prefs/pref_hash_store.h

+++ b/chrome/browser/prefs/pref_hash_store.h

@@ -9,8 +9,6 @@

#include "base/memory/scoped_ptr.h"

-class PrefHashTracker;

namespace base {

class Value;

} // namespace base

@@ -41,7 +39,7 @@ class PrefHashStore {

virtual ValueState CheckValue(

const std::string& path, const base::Value* initial_value) const = 0;

- // Stores a hash of the current value of the preference at |path|.

+ // Stores a hash of the current |value| of the preference at |path|.

virtual void StoreHash(const std::string& path,

const base::Value* value) = 0;

};