Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: cc/playback/display_item.h

Issue 1226503006: cc: More consistent reasoning about display list memory usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: capacity unit test Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_PLAYBACK_DISPLAY_ITEM_H_ 5 #ifndef CC_PLAYBACK_DISPLAY_ITEM_H_
6 #define CC_PLAYBACK_DISPLAY_ITEM_H_ 6 #define CC_PLAYBACK_DISPLAY_ITEM_H_
7 7
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "cc/base/cc_export.h" 9 #include "cc/base/cc_export.h"
10 #include "cc/debug/traced_value.h" 10 #include "cc/debug/traced_value.h"
11 #include "third_party/skia/include/core/SkPicture.h" 11 #include "third_party/skia/include/core/SkPicture.h"
12 #include "ui/gfx/geometry/rect.h" 12 #include "ui/gfx/geometry/rect.h"
13 13
14 class SkCanvas; 14 class SkCanvas;
15 15
16 namespace cc { 16 namespace cc {
17 17
18 class CC_EXPORT DisplayItem { 18 class CC_EXPORT DisplayItem {
19 public: 19 public:
20 virtual ~DisplayItem() {} 20 virtual ~DisplayItem() {}
21 21
22 void SetNew(bool is_suitable_for_gpu_rasterization, 22 void SetNew(bool is_suitable_for_gpu_rasterization,
23 int approximate_op_count, 23 int approximate_op_count,
24 size_t picture_memory_usage) { 24 size_t external_memory_usage) {
25 is_suitable_for_gpu_rasterization_ = is_suitable_for_gpu_rasterization; 25 is_suitable_for_gpu_rasterization_ = is_suitable_for_gpu_rasterization;
26 approximate_op_count_ = approximate_op_count; 26 approximate_op_count_ = approximate_op_count;
27 picture_memory_usage_ = 27 external_memory_usage_ = external_memory_usage;
28 picture_memory_usage + sizeof(bool) + sizeof(int) + sizeof(size_t);
29 } 28 }
30 29
31 virtual void Raster(SkCanvas* canvas, 30 virtual void Raster(SkCanvas* canvas,
32 const gfx::Rect& canvas_target_playback_rect, 31 const gfx::Rect& canvas_target_playback_rect,
33 SkPicture::AbortCallback* callback) const = 0; 32 SkPicture::AbortCallback* callback) const = 0;
34 virtual void AsValueInto(base::trace_event::TracedValue* array) const = 0; 33 virtual void AsValueInto(base::trace_event::TracedValue* array) const = 0;
35 34
36 bool is_suitable_for_gpu_rasterization() const { 35 bool is_suitable_for_gpu_rasterization() const {
37 return is_suitable_for_gpu_rasterization_; 36 return is_suitable_for_gpu_rasterization_;
38 } 37 }
39 int approximate_op_count() const { return approximate_op_count_; } 38 int approximate_op_count() const { return approximate_op_count_; }
40 size_t picture_memory_usage() const { return picture_memory_usage_; } 39 size_t external_memory_usage() const { return external_memory_usage_; }
41 40
42 protected: 41 protected:
43 DisplayItem(); 42 DisplayItem();
44 43
45 bool is_suitable_for_gpu_rasterization_; 44 bool is_suitable_for_gpu_rasterization_;
46 int approximate_op_count_; 45 int approximate_op_count_;
47 size_t picture_memory_usage_; 46
47 // The size, in bytes, of the memory owned by this display item but not
48 // allocated within it (e.g. held through scoped_ptr or vector).
49 size_t external_memory_usage_;
48 }; 50 };
49 51
50 } // namespace cc 52 } // namespace cc
51 53
52 #endif // CC_PLAYBACK_DISPLAY_ITEM_H_ 54 #endif // CC_PLAYBACK_DISPLAY_ITEM_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698