Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Side by Side Diff: src/objects.cc

Issue 1226473003: Cleanup API property handling (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.h ('k') | src/runtime/runtime-object.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <iomanip> 5 #include <iomanip>
6 #include <sstream> 6 #include <sstream>
7 7
8 #include "src/v8.h" 8 #include "src/v8.h"
9 9
10 #include "src/accessors.h" 10 #include "src/accessors.h"
(...skipping 5220 matching lines...) Expand 10 before | Expand all | Expand 10 after
5231 uint32_t index, 5231 uint32_t index,
5232 LanguageMode language_mode) { 5232 LanguageMode language_mode) {
5233 LookupIterator it(object->GetIsolate(), object, index); 5233 LookupIterator it(object->GetIsolate(), object, index);
5234 return DeleteProperty(&it, language_mode); 5234 return DeleteProperty(&it, language_mode);
5235 } 5235 }
5236 5236
5237 5237
5238 MaybeHandle<Object> JSReceiver::DeleteProperty(Handle<JSReceiver> object, 5238 MaybeHandle<Object> JSReceiver::DeleteProperty(Handle<JSReceiver> object,
5239 Handle<Name> name, 5239 Handle<Name> name,
5240 LanguageMode language_mode) { 5240 LanguageMode language_mode) {
5241 LookupIterator it(object, name, LookupIterator::HIDDEN);
5242 return JSObject::DeleteProperty(&it, language_mode);
5243 }
5244
5245
5246 MaybeHandle<Object> JSReceiver::DeletePropertyOrElement(
5247 Handle<JSReceiver> object, Handle<Name> name, LanguageMode language_mode) {
5241 LookupIterator it = LookupIterator::PropertyOrElement( 5248 LookupIterator it = LookupIterator::PropertyOrElement(
5242 name->GetIsolate(), object, name, LookupIterator::HIDDEN); 5249 name->GetIsolate(), object, name, LookupIterator::HIDDEN);
5243 return JSObject::DeleteProperty(&it, language_mode); 5250 return JSObject::DeleteProperty(&it, language_mode);
5244 } 5251 }
5245 5252
5246 5253
5247 bool JSObject::ReferencesObjectFromElements(FixedArray* elements, 5254 bool JSObject::ReferencesObjectFromElements(FixedArray* elements,
5248 ElementsKind kind, 5255 ElementsKind kind,
5249 Object* object) { 5256 Object* object) {
5250 DCHECK(IsFastObjectElementsKind(kind) || 5257 DCHECK(IsFastObjectElementsKind(kind) ||
(...skipping 10843 matching lines...) Expand 10 before | Expand all | Expand 10 after
16094 Handle<Object> new_value) { 16101 Handle<Object> new_value) {
16095 if (cell->value() != *new_value) { 16102 if (cell->value() != *new_value) {
16096 cell->set_value(*new_value); 16103 cell->set_value(*new_value);
16097 Isolate* isolate = cell->GetIsolate(); 16104 Isolate* isolate = cell->GetIsolate();
16098 cell->dependent_code()->DeoptimizeDependentCodeGroup( 16105 cell->dependent_code()->DeoptimizeDependentCodeGroup(
16099 isolate, DependentCode::kPropertyCellChangedGroup); 16106 isolate, DependentCode::kPropertyCellChangedGroup);
16100 } 16107 }
16101 } 16108 }
16102 } // namespace internal 16109 } // namespace internal
16103 } // namespace v8 16110 } // namespace v8
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/runtime/runtime-object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698