Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 1226473003: Cleanup API property handling (Closed)

Created:
5 years, 5 months ago by Toon Verwaest
Modified:
5 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Cleanup API property handling BUG=v8:4137 LOG=n Committed: https://crrev.com/d550e818916e0c4f27062137e5202ac6bc98da01 Cr-Commit-Position: refs/heads/master@{#29444}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -37 lines) Patch
M src/api.cc View 2 chunks +9 lines, -36 lines 0 comments Download
M src/objects.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
ptal
5 years, 5 months ago (2015-07-02 11:48:40 UTC) #2
Jakob Kummerow
lgtm
5 years, 5 months ago (2015-07-02 12:08:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226473003/1
5 years, 5 months ago (2015-07-02 12:38:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-02 13:29:54 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 13:30:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d550e818916e0c4f27062137e5202ac6bc98da01
Cr-Commit-Position: refs/heads/master@{#29444}

Powered by Google App Engine
This is Rietveld 408576698