Chromium Code Reviews

Issue 1226443004: [turbofan] VisitSuperCallReference is not reachable (Closed)

Created:
5 years, 5 months ago by arv (Not doing code reviews)
Modified:
5 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] VisitSuperCallReference is not reachable BUG=N LOG=N R=mstarzinger@chromium.org Committed: https://crrev.com/01fe045b69e31db1ea0639b3fa838e3a23df7cb6 Cr-Commit-Position: refs/heads/master@{#29522}

Patch Set 1 : #

Unified diffs Side-by-side diffs Stats (+2 lines, -2 lines)
M src/compiler/ast-graph-builder.cc View 1 chunk +2 lines, -2 lines 0 comments

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226443004/1
5 years, 5 months ago (2015-07-07 16:26:56 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226443004/20001
5 years, 5 months ago (2015-07-07 16:28:16 UTC) #5
arv (Not doing code reviews)
PTAL It was unreachable as it should have been.
5 years, 5 months ago (2015-07-07 16:28:47 UTC) #6
Michael Starzinger
LGTM.
5 years, 5 months ago (2015-07-07 16:48:26 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-07 16:51:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226443004/20001
5 years, 5 months ago (2015-07-07 18:29:23 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 5 months ago (2015-07-07 18:30:48 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 18:31:08 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/01fe045b69e31db1ea0639b3fa838e3a23df7cb6
Cr-Commit-Position: refs/heads/master@{#29522}

Powered by Google App Engine