Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 1226403007: Use SK_DECLARE_STATIC_MUTEX for global mutex. (Closed)

Created:
5 years, 5 months ago by mtklein_C
Modified:
5 years, 5 months ago
Reviewers:
mtklein, reed2
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use SK_DECLARE_STATIC_MUTEX for global mutex. This initializes the mutex at link time on non-Windows platforms, rather than at pre-main-runtime like `static SkMutex gFoo;` BUG=skia: Committed: https://skia.googlesource.com/skia/+/4598fc3c123cd8af1dac5596f955a375186a31f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/ports/SkFontHost_mac.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
mtklein
lgtm
5 years, 5 months ago (2015-07-13 12:49:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226403007/1
5 years, 5 months ago (2015-07-13 12:49:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/4598fc3c123cd8af1dac5596f955a375186a31f3
5 years, 5 months ago (2015-07-13 13:15:39 UTC) #5
reed2
5 years, 5 months ago (2015-07-13 21:32:39 UTC) #7
Message was sent while issue was closed.
doh. thanks.

Powered by Google App Engine
This is Rietveld 408576698