Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: base/android/junit/src/org/chromium/base/BaseChromiumApplicationTest.java

Issue 1226373010: Roll android_tools repo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert MENU workaround Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/android/java/src/org/chromium/base/BaseChromiumApplication.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/junit/src/org/chromium/base/BaseChromiumApplicationTest.java
diff --git a/base/android/junit/src/org/chromium/base/BaseChromiumApplicationTest.java b/base/android/junit/src/org/chromium/base/BaseChromiumApplicationTest.java
index 0aa9ccd388faa95cc93944810ed9077c06b50e1b..d3441f7895fed53357bb427c05a25cb8cd42eac5 100644
--- a/base/android/junit/src/org/chromium/base/BaseChromiumApplicationTest.java
+++ b/base/android/junit/src/org/chromium/base/BaseChromiumApplicationTest.java
@@ -8,6 +8,7 @@ import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
import android.app.Activity;
+import android.view.KeyEvent;
import junit.framework.Assert;
@@ -38,6 +39,12 @@ public class BaseChromiumApplicationTest {
public void onWindowFocusChanged(@SuppressWarnings("unused") boolean hasFocus) {
mWindowFocusCalls++;
}
+
+ @Implementation
+ public boolean dispatchKeyEvent(@SuppressWarnings("unused") KeyEvent event) {
+ mDispatchKeyEventCalls++;
+ return mReturnValueForKeyDispatch;
+ }
}
@Test
@@ -58,4 +65,30 @@ public class BaseChromiumApplicationTest {
// Also ensure that the original activity is forwarded the notification.
Assert.assertEquals(1, shadow.mWindowFocusCalls);
}
+
+ @Test
+ public void testDispatchKeyEvent() throws Exception {
+ ActivityController<Activity> controller =
+ Robolectric.buildActivity(Activity.class).create().start().visible();
+ TrackingShadowActivity shadow =
+ (TrackingShadowActivity) Robolectric.shadowOf(controller.get());
+
+ final KeyEvent menuKey = new KeyEvent(KeyEvent.ACTION_DOWN, KeyEvent.KEYCODE_MENU);
+
+ // Ensure that key events are forwarded.
+ Assert.assertFalse(controller.get().getWindow().getCallback().dispatchKeyEvent(menuKey));
+ // This gets called twice - once to see if the activity is swallowing it, and again to
+ // dispatch it.
+ Assert.assertEquals(2, shadow.mDispatchKeyEventCalls);
+
+ // Ensure that our activity can swallow the event.
+ shadow.mReturnValueForKeyDispatch = true;
+ Assert.assertTrue(controller.get().getWindow().getCallback().dispatchKeyEvent(menuKey));
+ Assert.assertEquals(3, shadow.mDispatchKeyEventCalls);
+
+ // A non-enter key only dispatches once.
+ Assert.assertTrue(controller.get().getWindow().getCallback().dispatchKeyEvent(
+ new KeyEvent(KeyEvent.ACTION_DOWN, KeyEvent.KEYCODE_SPACE)));
+ Assert.assertEquals(4, shadow.mDispatchKeyEventCalls);
+ }
}
« no previous file with comments | « base/android/java/src/org/chromium/base/BaseChromiumApplication.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698