base/logging.h - Issue 1226373007: Improve comment in logging.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/logging.h

Issue 1226373007: Improve comment in logging.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/logging.h

diff --git a/base/logging.h b/base/logging.h

index ea096d19f729cb9043b0a6fcaea7a935e0d943aa..21ba1f85082f55cdd21b41d4c6ac7c9465c4544c 100644

--- a/base/logging.h

+++ b/base/logging.h

@@ -436,7 +436,7 @@ const LogSeverity LOG_0 = LOG_ERROR;

#if defined(OFFICIAL_BUILD) && defined(NDEBUG) && !defined(OS_ANDROID)

// Make all CHECK functions discard their log strings to reduce code

-// bloat for official release builds.

+// bloat for official release builds (except Android).

// TODO(akalin): This would be more valuable if there were some way to

// remove BreakDebugger() from the backtrace, perhaps by turning it

« no previous file with comments | « no previous file | no next file » | no next file with comments »