Issue 1226373007: Improve comment in logging.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1226373007: Improve comment in logging.h. (Closed)

Created:
5 years, 5 months ago by Thiemo Nagel

Modified:
5 years, 5 months ago

Reviewers:
Nico

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Improve comment in logging.h. R=thakis@chromium.org BUG=None Committed: https://crrev.com/be15c56b700d2f16523a22d5bdf8ab163b49112c Cr-Commit-Position: refs/heads/master@{#338452}

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	base/logging.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (1 generated)

Thiemo Nagel

Hi Nico, let's clarify this comment... Kind regards, Thiemo

5 years, 5 months ago (2015-07-11 09:06:42 UTC) #1

Nico

lgtm Now I vaguely remembering that patch. I think I wasn't a fan since it ...

5 years, 5 months ago (2015-07-11 17:24:11 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226373007/1

5 years, 5 months ago (2015-07-12 13:02:57 UTC) #4

commit-bot: I haz the power

5 years, 5 months ago (2015-07-12 14:18:58 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/be15c56b700d2f16523a22d5bdf8ab163b49112c
Cr-Commit-Position: refs/heads/master@{#338452}