Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 1226373004: [Telemetry] Remove adb_commands from android_browser_backend and android_browser_backend_setting (Closed)

Created:
5 years, 5 months ago by sullivan
Modified:
5 years, 5 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land https://codereview.chromium.org/1213423003/ The original patch has been uploaded in patch set 2 to make the diff clearer. Remove adb_commands from android_browser_backend and android_browser_backend_settings. Pulled from https://codereview.chromium.org/1167173002/ BUG=476709 Committed: https://crrev.com/6baec756afca1f9949f6ff0e0252dd070bb86349 Cr-Commit-Position: refs/heads/master@{#338313}

Patch Set 1 #

Patch Set 2 : DO NOT SUBMIT: original patchset that was reverted #

Patch Set 3 : Patchset to land #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -89 lines) Patch
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 16 chunks +22 lines, -22 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend_unittest.py View 6 chunks +60 lines, -25 lines 0 comments Download
M tools/telemetry/telemetry/internal/backends/android_browser_backend_settings.py View 2 5 chunks +19 lines, -19 lines 0 comments Download
M tools/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py View 7 chunks +18 lines, -20 lines 0 comments Download
M tools/telemetry/telemetry/internal/forwarders/android_forwarder.py View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
sullivan
5 years, 5 months ago (2015-07-10 14:41:16 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226373004/1
5 years, 5 months ago (2015-07-10 15:09:51 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226373004/40001
5 years, 5 months ago (2015-07-10 15:16:03 UTC) #6
nednguyen
+Ken: what test do we run to make sure that this doesn't break android_webview_webgl_conformance_tests Would ...
5 years, 5 months ago (2015-07-10 15:57:05 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-10 16:28:24 UTC) #10
nednguyen
lgtm
5 years, 5 months ago (2015-07-10 17:17:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226373004/40001
5 years, 5 months ago (2015-07-10 17:19:08 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-10 17:25:17 UTC) #14
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/6baec756afca1f9949f6ff0e0252dd070bb86349 Cr-Commit-Position: refs/heads/master@{#338313}
5 years, 5 months ago (2015-07-10 17:26:14 UTC) #15
Ken Russell (switch to Gerrit)
On 2015/07/10 15:57:05, nednguyen wrote: > +Ken: what test do we run to make sure ...
5 years, 5 months ago (2015-07-10 20:21:47 UTC) #17
Ken Russell (switch to Gerrit)
On 2015/07/10 20:21:47, Ken Russell wrote: > On 2015/07/10 15:57:05, nednguyen wrote: > > +Ken: ...
5 years, 5 months ago (2015-07-10 20:27:33 UTC) #18
alex clarke (OOO till 29th)
5 years, 5 months ago (2015-07-13 11:31:30 UTC) #19

Powered by Google App Engine
This is Rietveld 408576698