Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1226363003: MIPS64: Refine 'Remove unused byte from Map::instance_sizes field.' (Closed)

Created:
5 years, 5 months ago by balazs.kilvady
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Refine 'Remove unused byte from Map::instance_sizes field.' Port 2027335f1ce44b0c6523eb5e55881e2a4e162815 Original commit message: Note that there are currently no objects that require a pre-allocated properties backing store, all such slots are in-object properties from the begining. Hence {unused + pre_allocated - inobject == 0} holds. BUG= Committed: https://crrev.com/9f9f27c3337589306b7f2248ccc472dd576a94c9 Cr-Commit-Position: refs/heads/master@{#29610}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M src/mips64/builtins-mips64.cc View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
balazs.kilvady
5 years, 5 months ago (2015-07-13 11:46:41 UTC) #2
Michael Starzinger
LGTM. Thanks. Sorry for not CC'ing you on the original CL. Will do so in ...
5 years, 5 months ago (2015-07-13 12:08:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226363003/1
5 years, 5 months ago (2015-07-13 13:06:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-13 13:36:08 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 13:36:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f9f27c3337589306b7f2248ccc472dd576a94c9
Cr-Commit-Position: refs/heads/master@{#29610}

Powered by Google App Engine
This is Rietveld 408576698