extensions/browser/api/system_display/display_info_provider.cc - Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/system_display/display_info_provider.cc

Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/system_display/display_info_provider.h ('k') | extensions/browser/api/system_display/system_display_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/system_display/display_info_provider.cc

diff --git a/extensions/browser/api/system_display/display_info_provider.cc b/extensions/browser/api/system_display/display_info_provider.cc

index 50a4c938629238b3e852ccf9d0a718a25b5e477d..41c75707ec77e5ea29d6b66aac70b07ad248c557 100644

--- a/extensions/browser/api/system_display/display_info_provider.cc

+++ b/extensions/browser/api/system_display/display_info_provider.cc

@@ -32,11 +32,11 @@ int RotationToDegrees(gfx::Display::Rotation rotation) {

}

// Creates new DisplayUnitInfo struct for |display|.

-core_api::system_display::DisplayUnitInfo* CreateDisplayUnitInfo(

+api::system_display::DisplayUnitInfo* CreateDisplayUnitInfo(

const gfx::Display& display,

int64 primary_display_id) {

- core_api::system_display::DisplayUnitInfo* unit =

- new core_api::system_display::DisplayUnitInfo();

+ api::system_display::DisplayUnitInfo* unit =

+ new api::system_display::DisplayUnitInfo();

const gfx::Rect& bounds = display.bounds();

const gfx::Rect& work_area = display.work_area();

unit->id = base::Int64ToString(display.id());

@@ -81,7 +81,7 @@ DisplayInfo DisplayInfoProvider::GetAllDisplaysInfo() {

std::vector<gfx::Display> displays = screen->GetAllDisplays();

DisplayInfo all_displays;

for (const gfx::Display& display : displays) {

- linked_ptr<core_api::system_display::DisplayUnitInfo> unit(

+ linked_ptr<api::system_display::DisplayUnitInfo> unit(

CreateDisplayUnitInfo(display, primary_id));

UpdateDisplayUnitInfoForPlatform(display, unit.get());

all_displays.push_back(unit);