extensions/browser/api/serial/serial_apitest.cc - Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/serial/serial_apitest.cc

Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/serial/serial_apitest.cc

diff --git a/extensions/browser/api/serial/serial_apitest.cc b/extensions/browser/api/serial/serial_apitest.cc

index 96ce89d8434975c398246998c4811f4e480ad7a8..ac22f661bfd3abf64adfe6ed6f7b40c3a24fa89b 100644

--- a/extensions/browser/api/serial/serial_apitest.cc

+++ b/extensions/browser/api/serial/serial_apitest.cc

@@ -83,7 +83,7 @@ class FakeEchoSerialIoHandler : public device::TestSerialIoHandler {

DISALLOW_COPY_AND_ASSIGN(FakeEchoSerialIoHandler);

};

-class FakeSerialConnectFunction : public core_api::SerialConnectFunction {

+class FakeSerialConnectFunction : public api::SerialConnectFunction {

protected:

SerialConnection* CreateSerialConnection(

const std::string& port,

« no previous file with comments | « extensions/browser/api/serial/serial_api.cc ('k') | extensions/browser/api/serial/serial_connection.h » ('j') | no next file with comments »