extensions/browser/api/networking_config/networking_config_api.h - Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/networking_config/networking_config_api.h

Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/management/management_api.cc ('k') | extensions/browser/api/networking_config/networking_config_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/networking_config/networking_config_api.h

diff --git a/extensions/browser/api/networking_config/networking_config_api.h b/extensions/browser/api/networking_config/networking_config_api.h

index c9c2be91b08e58e2ab2eb2090811fb8eea92083d..72601bd7cc09480b42a5d417fdf61f93981f4898 100644

--- a/extensions/browser/api/networking_config/networking_config_api.h

+++ b/extensions/browser/api/networking_config/networking_config_api.h

@@ -23,8 +23,7 @@ class NetworkingConfigSetNetworkFilterFunction

protected:

~NetworkingConfigSetNetworkFilterFunction() override;

- scoped_ptr<core_api::networking_config::SetNetworkFilter::Params>

- parameters_;

+ scoped_ptr<api::networking_config::SetNetworkFilter::Params> parameters_;

private:

DISALLOW_COPY_AND_ASSIGN(NetworkingConfigSetNetworkFilterFunction);

@@ -43,8 +42,7 @@ class NetworkingConfigFinishAuthenticationFunction

protected:

~NetworkingConfigFinishAuthenticationFunction() override;

- scoped_ptr<core_api::networking_config::FinishAuthentication::Params>

- parameters_;

+ scoped_ptr<api::networking_config::FinishAuthentication::Params> parameters_;

private:

DISALLOW_COPY_AND_ASSIGN(NetworkingConfigFinishAuthenticationFunction);