chrome/browser/extensions/chrome_extensions_browser_client.h - Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/chrome_extensions_browser_client.h

Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_request/web_request_api_unittest.cc ('k') | chrome/browser/extensions/chrome_extensions_browser_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/chrome_extensions_browser_client.h

diff --git a/chrome/browser/extensions/chrome_extensions_browser_client.h b/chrome/browser/extensions/chrome_extensions_browser_client.h

index b47d3e98428af554d59e4900b77076b6bf68f02a..b59acbdc5eab38128e4f8ff26522d96a34ad7581 100644

--- a/chrome/browser/extensions/chrome_extensions_browser_client.h

+++ b/chrome/browser/extensions/chrome_extensions_browser_client.h

@@ -29,7 +29,7 @@ class ChromeExtensionsAPIClient;

class ChromeProcessManagerDelegate;

class ContentSettingsPrefsObserver;

-// Implementation of extensions::BrowserClient for Chrome, which includes

+// Implementation of BrowserClient for Chrome, which includes

// knowledge of Profiles, BrowserContexts and incognito.

// NOTE: Methods that do not require knowledge of browser concepts should be

@@ -61,7 +61,7 @@ class ChromeExtensionsBrowserClient : public ExtensionsBrowserClient {

const std::string& extension_id,

content::BrowserContext* context) const override;

bool CanExtensionCrossIncognito(

- const extensions::Extension* extension,

+ const Extension* extension,

content::BrowserContext* context) const override;

net::URLRequestJob* MaybeCreateResourceBundleRequestJob(

net::URLRequest* request,

@@ -91,7 +91,7 @@ class ChromeExtensionsBrowserClient : public ExtensionsBrowserClient {

ExtensionFunctionRegistry* registry) const override;

void RegisterMojoServices(content::RenderFrameHost* render_frame_host,

const Extension* extension) const override;

- scoped_ptr<extensions::RuntimeAPIDelegate> CreateRuntimeAPIDelegate(

+ scoped_ptr<RuntimeAPIDelegate> CreateRuntimeAPIDelegate(

content::BrowserContext* context) const override;

const ComponentExtensionResourceManager*

GetComponentExtensionResourceManager() override;