build/json_schema_bundle_compile.gypi - Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/json_schema_bundle_compile.gypi

Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/json_schema_bundle_compile.gypi

diff --git a/build/json_schema_bundle_compile.gypi b/build/json_schema_bundle_compile.gypi

index a3020136d3fee863ca9fac71fd4910b22d0893da..2101a89655522e8892eca448a4bb73fc738d1b41 100644

--- a/build/json_schema_bundle_compile.gypi

+++ b/build/json_schema_bundle_compile.gypi

@@ -18,6 +18,10 @@

# A Python string substituion pattern used to generate the C++

# namespace for each API. Use %(namespace)s to replace with the API

# namespace, like "toplevel::%(namespace)s_api".

+ # bundle_name:

+ # A string to prepend to generated bundle class names, so that multiple

+ # bundle rules can be used without conflicting. Only used with one of

+ # the cpp-bundle generators.

# Functions and namespaces can be excluded by setting "nocompile" to true.

# The default root path of API implementation sources is

@@ -57,6 +61,7 @@

'--root=<(DEPTH)',

'--destdir=<(SHARED_INTERMEDIATE_DIR)',

'--namespace=<(root_namespace)',

+ '--bundle-name=<(bundle_name)',

'--generator=cpp-bundle-schema',

'--include-rules=<(schema_include_rules)',

'<@(schema_files)',

« no previous file with comments | « build/json_schema_api.gni ('k') | build/json_schema_bundle_registration_compile.gypi » ('j') | no next file with comments »