Refactor SpecialPopupRow out of tray_views.h/cc into its own files.

Refactor SpecialPopupRow out of tray_views.h/cc into its own files.


BUG=176144
TBR=sky

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182360

[stevenjb, 2013-02-13 23:13:16]

Thanks for doing this, just one real change request.

https://codereview.chromium.org/12263021/diff/1/ash/system/tray/special_popup...
File ash/system/tray/special_popup_row.cc (right):

https://codereview.chromium.org/12263021/diff/1/ash/system/tray/special_popup...
ash/system/tray/special_popup_row.cc:21: namespace {
nit: ws

https://codereview.chromium.org/12263021/diff/1/ash/system/tray/special_popup...
ash/system/tray/special_popup_row.cc:113: 
nit: no need for extra WS here

https://codereview.chromium.org/12263021/diff/1/ash/system/tray/special_popup...
ash/system/tray/special_popup_row.cc:122: 
nit: no need for extra WS here

https://codereview.chromium.org/12263021/diff/1/ash/system/tray/tray_details_...
File ash/system/tray/tray_details_view.h (right):

https://codereview.chromium.org/12263021/diff/1/ash/system/tray/tray_details_...
ash/system/tray/tray_details_view.h:8: #include
"ash/system/tray/special_popup_row.h"
Can we avoid this? It looks like we just need to add it to two .cc files.

[jennyz, 2013-02-13 23:36:57]

https://codereview.chromium.org/12263021/diff/1/ash/system/tray/special_popup...
File ash/system/tray/special_popup_row.cc (right):

https://codereview.chromium.org/12263021/diff/1/ash/system/tray/special_popup...
ash/system/tray/special_popup_row.cc:21: namespace {
On 2013/02/13 23:13:16, stevenjb (chromium) wrote:
> nit: ws

Done.

https://codereview.chromium.org/12263021/diff/1/ash/system/tray/special_popup...
ash/system/tray/special_popup_row.cc:113: 
On 2013/02/13 23:13:16, stevenjb (chromium) wrote:
> nit: no need for extra WS here

Done.

https://codereview.chromium.org/12263021/diff/1/ash/system/tray/special_popup...
ash/system/tray/special_popup_row.cc:122: 
On 2013/02/13 23:13:16, stevenjb (chromium) wrote:
> nit: no need for extra WS here

Done.

https://codereview.chromium.org/12263021/diff/1/ash/system/tray/tray_details_...
File ash/system/tray/tray_details_view.h (right):

https://codereview.chromium.org/12263021/diff/1/ash/system/tray/tray_details_...
ash/system/tray/tray_details_view.h:8: #include
"ash/system/tray/special_popup_row.h"
On 2013/02/13 23:13:16, stevenjb (chromium) wrote:
> Can we avoid this? It looks like we just need to add it to two .cc files.
It is more convenient to include it here, otherwise, we will need to include it
in all the tray_xx.cc files where footer() is accessed in the TrayDetailsView
derived class, which are a lot(9 files).

[stevenjb, 2013-02-14 00:16:27]

lgtm

[commit-bot: I haz the power, 2013-02-14 00:21:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jennyz@chromium.org/12263021/5001

[commit-bot: I haz the power, 2013-02-14 00:22:11]

Presubmit check for 12263021-5001 failed and returned exit status 1.

INFO:root:Found 6 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/ash/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    ash

Presubmit checks took 1.4s to calculate.

[commit-bot: I haz the power, 2013-02-14 00:25:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jennyz@chromium.org/12263021/5001

[commit-bot: I haz the power, 2013-02-14 00:59:25]

Retried try job too often on linux_aura for step(s) aura_unittests,
browser_tests, compositor_unittests, content_browsertests, content_unittests,
interactive_ui_tests, unit_tests, views_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...