Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 12263014: Revert 179916. It breaks on Mac. (Closed)

Created:
7 years, 10 months ago by Matt Perry
Modified:
7 years, 10 months ago
Reviewers:
Finnur
CC:
chromium-reviews, Aaron Boodman, tfarina, arv+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Revert 179916. It breaks on Mac. > Add a link (to view Permissions) to the Extension details on chrome://extensions. > > BUG=170742 > TEST=None > > Review URL: https://chromiumcodereview.appspot.com/12094034 BUG=170742, 175071 TBR=finnur@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182274

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -113 lines) Patch
M chrome/app/generated_resources.grd View 4 chunks +1 line, -14 lines 0 comments Download
M chrome/browser/extensions/extension_install_prompt.h View 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 9 chunks +1 line, -32 lines 0 comments Download
M chrome/browser/resources/extensions/extension_list.js View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/resources/extensions/extensions.html View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_install_dialog_view.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.h View 5 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 4 chunks +0 lines, -25 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Matt Perry
7 years, 10 months ago (2013-02-13 18:58:45 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698