media: Add support for playback of VP8 Alpha video streams

media/base/decoder_buffer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_DECODER_BUFFER_H_
 #define MEDIA_BASE_DECODER_BUFFER_H_
 
 #include <string>
 
 #include "base/memory/aligned_memory.h"
@@ skipping 46 matching lines @@
   void SetTimestamp(const base::TimeDelta& timestamp);
 
   base::TimeDelta GetDuration() const;
   void SetDuration(const base::TimeDelta& duration);
 
   const uint8* GetData() const;
   uint8* GetWritableData() const;
 
   int GetDataSize() const;
 
+  const uint8* GetSideData() const;
+  int GetSideDataSize() const;
+
   const DecryptConfig* GetDecryptConfig() const;
   void SetDecryptConfig(scoped_ptr<DecryptConfig> decrypt_config);
 
   // If there's no data in this buffer, it represents end of stream.
   bool IsEndOfStream() const;
 
   // Returns a human-readable string describing |*this|.
   std::string AsHumanReadableString();
 
+  // Allocate memory and copy side data. Padded and aligned as necessary
+  virtual void SetSideData(const uint8* data, int size);

[scherkus (not reviewing), 2013/02/22 23:18:01]

I've been trying to move away from these data setter functions.

Can you refactor this to intoduce an overloaded CopyFrom() function that accepts
the side data?

[vignesh, 2013/02/25 21:51:42]

Done.

+
  protected:
   friend class base::RefCountedThreadSafe<DecoderBuffer>;
 
   // Allocates a buffer of size |size| >= 0 and copies |data| into it.  Buffer
   // will be padded and aligned as necessary.  If |data| is NULL then |data_| is
   // set to NULL and |buffer_size_| to 0.
   DecoderBuffer(const uint8* data, int size);
   virtual ~DecoderBuffer();
 
  private:
   base::TimeDelta timestamp_;
   base::TimeDelta duration_;
 
   int size_;
   scoped_ptr<uint8, base::ScopedPtrAlignedFree> data_;
+  int side_data_size_;
+  scoped_ptr<uint8, base::ScopedPtrAlignedFree> side_data_;
   scoped_ptr<DecryptConfig> decrypt_config_;
 
   // Constructor helper method for memory allocations.
   void Initialize();
 
   DISALLOW_COPY_AND_ASSIGN(DecoderBuffer);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_DECODER_BUFFER_H_