Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 12263004: Allow full inlining of f.apply(this, arguments) calls. (Closed)

Created:
7 years, 10 months ago by Michael Starzinger
Modified:
7 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Allow full inlining of f.apply(this, arguments) calls. This allows Crankshaft to completely inline a f.apply() dispatch if the exact number of arguments is known and the function is constant. The deoptimizer doesn't generate the f.apply() frame during deoptimization, so the materialized frames look like f.apply() did a tailcall. R=jkummerow@chromium.org TEST=mjsunit/compiler/inline-function-apply Committed: http://code.google.com/p/v8/source/detail?r=13665

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -40 lines) Patch
M src/hydrogen.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +30 lines, -7 lines 0 comments Download
A + test/mjsunit/compiler/inline-function-apply.js View 1 chunk +54 lines, -33 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
https://codereview.chromium.org/12263004/diff/1/test/mjsunit/compiler/inline-function-apply.js File test/mjsunit/compiler/inline-function-apply.js (right): https://codereview.chromium.org/12263004/diff/1/test/mjsunit/compiler/inline-function-apply.js#newcode51 test/mjsunit/compiler/inline-function-apply.js:51: // TODO(2539): Enable the mutation below once bug is ...
7 years, 10 months ago (2013-02-13 11:53:00 UTC) #1
Jakob Kummerow
7 years, 10 months ago (2013-02-13 12:18:46 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698