Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1226293002: Fix virtual/override/final usage in Source/core/{animation,css,style}/. (Closed)

Created:
5 years, 5 months ago by tkent
Modified:
5 years, 5 months ago
Reviewers:
dstockwell
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-events_chromium.org, blink-reviews-style_chromium.org, dglazkov+blink, eae+blinkwatch, Eric Willigers, kenneth.christiansen, rjwright, rwlbuis, shans, Yoav Weiss
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix virtual/override/final usage in Source/core/{animation,css,style}/. - We should specify just one of them to a function. This was done by the following command. % sed -i "" -E "s/virtual (.*) final/\1 final/g; s/virtual (.*) override/\1 override/g; s/override final/final/g" <files> - Non-base virtual destructors should have |override| keywords. This CL has no behavior changes. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198745

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+545 lines, -545 lines) Patch
M Source/core/animation/AngleSVGInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/Animation.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/animation/AnimationEffectTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/AnimationTimeline.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/animation/CSSValueInterpolationType.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/animation/ColorStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/CompositorAnimationsTestHelper.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ConstantStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/DefaultSVGInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/DeferredLegacyStyleInterpolation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/DoubleStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ImageSliceStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ImageStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/InertEffect.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/IntegerOptionalIntegerSVGInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/IntegerSVGInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/InterpolableValue.h View 5 chunks +20 lines, -20 lines 0 comments Download
M Source/core/animation/InterpolableValueTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/InterpolationEffectTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/KeyframeEffect.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/animation/KeyframeEffectModel.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/LegacyStyleInterpolation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/LengthBoxStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/LengthPairStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/LengthSVGInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/LengthStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ListStyleInterpolation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/NumberOptionalNumberSVGInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/NumberSVGInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/PathSVGInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/PrimitiveInterpolation.h View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/RectSVGInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/SVGInterpolation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/SVGStrokeDasharrayStyleInterpolation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/StringKeyframe.h View 5 chunks +13 lines, -13 lines 0 comments Download
M Source/core/animation/StyleInterpolation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/VisibilityStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableClipPathOperation.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableColor.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/animatable/AnimatableDouble.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableDoubleAndBool.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableFilterOperations.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableImage.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableLength.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/animatable/AnimatableLengthBox.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/animatable/AnimatableLengthBoxAndBool.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableLengthPoint.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/animatable/AnimatableLengthPoint3D.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/animatable/AnimatableLengthSize.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/animatable/AnimatableNeutral.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/animatable/AnimatableRepeatable.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableSVGPaint.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableShadow.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableShapeValue.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableStrokeDasharrayList.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/animatable/AnimatableTransform.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/animatable/AnimatableUnknown.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableValueKeyframe.h View 3 chunks +9 lines, -9 lines 0 comments Download
M Source/core/animation/animatable/AnimatableVisibility.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/BinaryDataFontFaceSource.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSBasicShapes.h View 7 chunks +12 lines, -12 lines 0 comments Download
M Source/core/css/CSSCalculationValue.cpp View 9 chunks +18 lines, -18 lines 0 comments Download
M Source/core/css/CSSCanvasValue.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.h View 2 chunks +19 lines, -19 lines 0 comments Download
M Source/core/css/CSSCrossfadeValue.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSCustomFontData.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/css/CSSFontFaceRule.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSFontSelector.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/css/CSSGroupingRule.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSImportRule.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSKeyframeRule.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSKeyframesRule.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSMediaRule.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSPageRule.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSRuleList.h View 3 chunks +11 lines, -11 lines 0 comments Download
M Source/core/css/CSSStyleRule.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSStyleSheet.h View 3 chunks +14 lines, -14 lines 0 comments Download
M Source/core/css/CSSStyleSheet.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/css/CSSSupportsRule.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSViewportRule.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/FontFace.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/FontFaceSet.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/css/FontFaceSet.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/FontFaceSetLoadEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/KeyframeStyleRuleCSSStyleDeclaration.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/LocalFontFaceSource.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/MediaQueryList.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/css/MediaQueryListEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/MediaQueryListTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/MediaValuesCached.h View 1 chunk +22 lines, -22 lines 0 comments Download
M Source/core/css/MediaValuesDynamic.h View 1 chunk +22 lines, -22 lines 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.h View 5 chunks +32 lines, -32 lines 0 comments Download
M Source/core/css/RemoteFontFaceSource.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/css/StyleRuleImport.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/style/BasicShapes.h View 4 chunks +17 lines, -17 lines 0 comments Download
M Source/core/style/ContentData.h View 8 chunks +16 lines, -16 lines 0 comments Download
M Source/core/style/PathStyleMotionPath.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/style/StyleFetchedImage.h View 1 chunk +18 lines, -18 lines 0 comments Download
M Source/core/style/StyleFetchedImageSet.h View 1 chunk +18 lines, -18 lines 0 comments Download
M Source/core/style/StyleGeneratedImage.h View 1 chunk +12 lines, -12 lines 0 comments Download
M Source/core/style/StylePendingImage.h View 1 chunk +12 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
dstockwell@, would you review this trivial patch please?
5 years, 5 months ago (2015-07-09 05:45:19 UTC) #2
dstockwell
lgtm
5 years, 5 months ago (2015-07-13 00:31:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226293002/1
5 years, 5 months ago (2015-07-13 00:54:23 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 02:17:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198745

Powered by Google App Engine
This is Rietveld 408576698