Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1226253005: Convert mojo::ErrorHandler usages into callbacks. (Closed)

Created:
5 years, 5 months ago by lwchkg
Modified:
5 years, 5 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

BUG=504666 Note: I am not in AUTHOR files yet. Please help by verifying that I have sign the CLA. Please also help by submitting the try jobs. Committed: https://crrev.com/a15bee4cc6b5163e30bf641af79a638a28147af9 Cr-Commit-Position: refs/heads/master@{#338433}

Patch Set 1 #

Patch Set 2 : Fix - forgot to remove override specifiers #

Patch Set 3 : Add lwchkg@gmail.com to AUTHORS file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
lwchkg
Dear all, Please help me to review the following: Issue 1226253005: Convert mojo::ErrorHandler usages into ...
5 years, 5 months ago (2015-07-10 04:34:40 UTC) #3
lwchkg
On 2015/07/10 04:34:40, lwchkg wrote: > Dear all, > > Please help me to review ...
5 years, 5 months ago (2015-07-10 12:48:55 UTC) #4
Avi (use Gerrit)
You've signed the CLA so you're ok there. LGTM
5 years, 5 months ago (2015-07-10 15:41:23 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226253005/20001
5 years, 5 months ago (2015-07-11 02:27:08 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/78077)
5 years, 5 months ago (2015-07-11 02:34:38 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226253005/40001
5 years, 5 months ago (2015-07-11 03:17:12 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-11 04:15:04 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226253005/40001
5 years, 5 months ago (2015-07-11 04:46:08 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-11 04:51:03 UTC) #23
commit-bot: I haz the power
5 years, 5 months ago (2015-07-11 04:51:52 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a15bee4cc6b5163e30bf641af79a638a28147af9
Cr-Commit-Position: refs/heads/master@{#338433}

Powered by Google App Engine
This is Rietveld 408576698