sync/internal_api/write_node.cc - Issue 1226213002: Sync: Support nodes with implicit permanent folders: Node Browser and out-of-order loading from DB

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/write_node.cc

Issue 1226213002: Sync: Support nodes with implicit permanent folders: Node Browser and out-of-order loading from DB (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/internal_api/write_node.cc

diff --git a/sync/internal_api/write_node.cc b/sync/internal_api/write_node.cc

index f3852b0f51b5cea1d40088ce3952843e4f476151..825e2eda0fd82f1b9200b396f0642fcce55ef00e 100644

--- a/sync/internal_api/write_node.cc

+++ b/sync/internal_api/write_node.cc

@@ -385,8 +385,8 @@ WriteNode::InitUniqueByCreationResult WriteNode::InitUniqueByCreationImpl(

// We don't support directory and tag combinations.

entry_->PutIsDir(false);

- if (!parent_id.IsNull()) {

- if (!PutPredecessor(NULL))

+ if (entry_->ShouldMaintainPosition()) {

+ if (!entry_->PutPredecessor(syncable::Id()))

return INIT_FAILED_SET_PREDECESSOR;

}

« no previous file with comments | « sync/internal_api/sync_manager_impl_unittest.cc ('k') | sync/syncable/entry_kernel.cc » ('j') | no next file with comments »