Sync: Support nodes with implicit permanent folders: Node Browser and out-of-order loading from DB

sync/syncable/parent_child_index_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/syncable/parent_child_index.h"
 
 #include <list>
 
 #include "base/stl_util.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 140 matching lines @@
 
 TEST_F(ParentChildIndexTest, TestRootNode) {
   EntryKernel* root = MakeRoot();
   EXPECT_FALSE(ParentChildIndex::ShouldInclude(root));
 }
 
 TEST_F(ParentChildIndexTest, TestBookmarkRootFolder) {
   EntryKernel* bm_folder = MakeBookmarkRoot();
   EXPECT_TRUE(ParentChildIndex::ShouldInclude(bm_folder));
 
+  index_.Insert(bm_folder);
+  // Since BOOKMARKS is a hierarchical type, its type root folder shouldn't be
+  // tracked by ParentChildIndex.
   EXPECT_EQ(Id(), IndexKnownModelTypeRootId(BOOKMARKS));
-  index_.Insert(bm_folder);
-  EXPECT_EQ(GetBookmarkRootId(), IndexKnownModelTypeRootId(BOOKMARKS));
 }
 
 // Tests iteration over a set of siblings.
 TEST_F(ParentChildIndexTest, ChildInsertionAndIteration) {
   EntryKernel* bm_folder = MakeBookmarkRoot();
   index_.Insert(bm_folder);
 
   // Make some folder and non-folder entries.
   EntryKernel* b1 = MakeBookmark(1, 1, false);
   EntryKernel* b2 = MakeBookmark(2, 2, false);
@@ skipping 269 matching lines @@
   index_.Insert(MakeUniqueClientItem(PREFERENCES, 4));
 
   children = index_.GetChildren(type_root);
   ASSERT_TRUE(children);
   // Should have 2 items. If the out of order removal cleared the implicit
   // parent folder ID prematurely, the collection would have 3 items including
   // p1.
   EXPECT_EQ(2UL, children->size());
 }
 
+// Test that the insert isn't sensitive to the order (Loading entries from
+// Sync DB is done in arbitrary order).
+TEST_F(ParentChildIndexTest, InsertOutOfOrder) {
+  // Insert two Preferences entries with implicit parent first
+  index_.Insert(MakeUniqueClientItem(PREFERENCES, 1));
+  index_.Insert(MakeUniqueClientItem(PREFERENCES, 2));
+
+  // Then insert the Preferences type root
+  syncable::Id type_root_id = syncable::Id::CreateFromServerId("type_root");
+  index_.Insert(MakeTypeRoot(PREFERENCES, type_root_id));
+
+  // The index should still be able to associate Preferences entries
+  // with the root.
+  const OrderedChildSet* children = index_.GetChildren(type_root_id);
+  ASSERT_TRUE(children);
+  EXPECT_EQ(2UL, children->size());
+}
+
 }  // namespace syncable
 }  // namespace syncer