chrome/browser/resources/sync_internals/node_browser.html - Issue 1226213002: Sync: Support nodes with implicit permanent folders: Node Browser and out-of-order loading from DB

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/sync_internals/node_browser.html

Issue 1226213002: Sync: Support nodes with implicit permanent folders: Node Browser and out-of-order loading from DB (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR feedback Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/sync_internals/data.js ('k') | chrome/browser/resources/sync_internals/sync_node_browser.js » ('j') | sync/syncable/parent_child_index.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!-- TODO(akalin): Move to a three-pane view; node tree on the left	1 <!-- TODO(akalin): Move to a three-pane view; node tree on the left

2 (minus leaf nodes), tree contents list on the upper right, selected	2 (minus leaf nodes), tree contents list on the upper right, selected

3 item detail on the lower right. -->	3 item detail on the lower right. -->

4	4

5 <div id="sync-node-main">	5 <div id="sync-node-main">

6 <!-- TODO(akalin): Figure out how to get this element to be as tall	6 <!-- TODO(akalin): Figure out how to get this element to be as tall

7 as its container (style.height=100% doesn't work). Also fix	7 as its container (style.height=100% doesn't work). Also fix

8 behavior when tree is too tall (currently it makes you scroll the	8 behavior when tree is too tall (currently it makes you scroll the

9 entire page). -->	9 entire page). -->

10 <div id="sync-node-browser-refresher">	10 <div id="sync-node-browser-refresher">

(...skipping 23 matching lines...) Expand all Loading...
34 <tr>	34 <tr>

35 <td>Parent</td>	35 <td>Parent</td>

36 <td jscontent="PARENT_ID"></td>	36 <td jscontent="PARENT_ID"></td>

37 </tr>	37 </tr>

38 <tr>	38 <tr>

39 <td>Is Folder</td>	39 <td>Is Folder</td>

40 <td jscontent="IS_DIR"></td>	40 <td jscontent="IS_DIR"></td>

41 </tr>	41 </tr>

42 <tr>	42 <tr>

43 <td>Type</td>	43 <td>Type</td>

44 <td jscontent="serverModelType"></td>	44 <td jscontent="modelType"></td>

45 </tr>	45 </tr>

46 <tr>	46 <tr>

47 <td>External ID</td>	47 <td>External ID</td>

48 <td jscontent="LOCAL_EXTERNAL_ID"></td>	48 <td jscontent="LOCAL_EXTERNAL_ID"></td>

49 </tr>	49 </tr>

50 <tr jsdisplay="$this.hasOwnProperty('positionIndex')">	50 <tr jsdisplay="$this.hasOwnProperty('positionIndex')">

51 <td>Position Index</td>	51 <td>Position Index</td>

52 <td jscontent="positionIndex"></td>	52 <td jscontent="positionIndex"></td>

53 </tr>	53 </tr>

54 </table>	54 </table>

55 <pre jscontent="JSON.stringify($this, null, 2)"></pre></td>	55 <pre jscontent="JSON.stringify($this, null, 2)"></pre></td>

56 </div>	56 </div>

57 </div>	57 </div>

58 </div>	58 </div>

OLD	NEW