Sync: Support nodes with implicit permanent folders: Node Browser and out-of-order loading from DB

sync/internal_api/sync_manager_impl_unittest.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Unit tests for the SyncApi. Note that a lot of the underlying
 // functionality is provided by the Syncable layer, which has its own
 // unit tests. We'll test SyncApi specific things in this harness.
 
 #include <cstddef>
 #include <map>
@@ skipping 155 matching lines @@
                                node_id);
   EXPECT_TRUE(entry.good());
   entry.PutBaseVersion(1);
   entry.PutServerVersion(1);
   entry.PutIsUnappliedUpdate(false);
   entry.PutParentId(syncable::Id::GetRoot());
   entry.PutServerParentId(syncable::Id::GetRoot());
   entry.PutServerIsDir(true);
   entry.PutIsDir(true);
   entry.PutServerSpecifics(specifics);
+  entry.PutSpecifics(specifics);
   entry.PutUniqueServerTag(type_tag);
   entry.PutNonUniqueName(type_tag);
   entry.PutIsDel(false);
-  entry.PutSpecifics(specifics);
   return entry.GetMetahandle();
 }
 
 // Simulates creating a "synced" node as a child of the root datatype node.
 int64 MakeServerNode(UserShare* share, ModelType model_type,
                      const std::string& client_tag,
                      const std::string& hashed_tag,
                      const sync_pb::EntitySpecifics& specifics) {
   syncable::WriteTransaction trans(
       FROM_HERE, syncable::UNITTEST, share->directory.get());
   syncable::Entry root_entry(&trans, syncable::GET_TYPE_ROOT, model_type);
   EXPECT_TRUE(root_entry.good());
   syncable::Id root_id = root_entry.GetId();
   syncable::Id node_id = syncable::Id::CreateFromServerId(client_tag);
   syncable::MutableEntry entry(&trans, syncable::CREATE_NEW_UPDATE_ITEM,
                                node_id);
   EXPECT_TRUE(entry.good());
   entry.PutBaseVersion(1);
   entry.PutServerVersion(1);
   entry.PutIsUnappliedUpdate(false);
   entry.PutServerParentId(root_id);
   entry.PutParentId(root_id);
   entry.PutServerIsDir(false);
   entry.PutIsDir(false);
   entry.PutServerSpecifics(specifics);
+  entry.PutSpecifics(specifics);
   entry.PutNonUniqueName(client_tag);
   entry.PutUniqueClientTag(hashed_tag);
   entry.PutIsDel(false);
-  entry.PutSpecifics(specifics);
   return entry.GetMetahandle();
 }
 
 }  // namespace
 
 class SyncApiTest : public testing::Test {
  public:
   void SetUp() override { test_user_share_.SetUp(); }
 
   void TearDown() override { test_user_share_.TearDown(); }
@@ skipping 3107 matching lines @@
 // SyncManagerInitInvalidStorageTest::GetFactory will return
 // DirectoryBackingStore that ensures that SyncManagerImpl::OpenDirectory fails.
 // SyncManagerImpl initialization is done in SyncManagerTest::SetUp. This test's
 // task is to ensure that SyncManagerImpl reported initialization failure in
 // OnInitializationComplete callback.
 TEST_F(SyncManagerInitInvalidStorageTest, FailToOpenDatabase) {
   EXPECT_FALSE(initialization_succeeded_);
 }
 
 }  // namespace syncer