Sync: Support nodes with implicit permanent folders: Node Browser and out-of-order loading from DB

sync/internal_api/write_node.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/internal_api/public/write_node.h"
 
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "sync/internal_api/public/base_transaction.h"
@@ skipping 367 matching lines @@
 
   if (!entry_->good())
     return INIT_FAILED_COULD_NOT_CREATE_ENTRY;
 
   // Has no impact if the client tag is already set.
   entry_->PutUniqueClientTag(hash);
 
   // We don't support directory and tag combinations.
   entry_->PutIsDir(false);
 
-  if (!parent_id.IsNull()) {
-    if (!PutPredecessor(NULL))
+  if (entry_->ShouldMaintainPosition()) {
+    if (!entry_->PutPredecessor(syncable::Id()))
       return INIT_FAILED_SET_PREDECESSOR;
   }
 
   // Mark this entry as unsynced, to wake up the syncer.
   MarkForSyncing();
 
   return INIT_SUCCESS;
 }
 
 bool WriteNode::SetPosition(const BaseNode& new_parent,
@@ skipping 63 matching lines @@
   syncable::Id predecessor_id = predecessor ?
       predecessor->GetEntry()->GetId() : syncable::Id();
   return entry_->PutPredecessor(predecessor_id);
 }
 
 void WriteNode::MarkForSyncing() {
   syncable::MarkForSyncing(entry_);
 }
 
 }  // namespace syncer