Issue 12262058: Revert r180578, r180591, and r180604 from 1410 branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12262058: Revert r180578, r180591, and r180604 from 1410 branch. (Closed)

Created:
7 years, 10 months ago by scherkus (not reviewing)

Modified:
7 years, 10 months ago

Reviewers:

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1410/src/

Visibility:
Public.

More Reviews

Description

Revert r180578, r180591, and r180604 from 1410 branch. r180578 removed media::VideoRendererBase::Get/PutCurrentFrame() but it introduced bugs when using hardware decoding. r180591 and r180604 were simple cleanup patches to remove reference counting but had to be reverted in order to revert r180578 cleanly. BUG=176036 TBR=tanyarad Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182597

Patch Set 1 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+526 lines, -328 lines)			Patch
M	content/renderer/media/rtc_video_decoder_unittest.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	media/base/audio_renderer.h	View	3 chunks	+8 lines, -4 lines	0 comments	Download
M	media/base/filter_collection.h	View	3 chunks	+14 lines, -8 lines	0 comments	Download
M	media/base/filter_collection.cc	View	1 chunk	+23 lines, -15 lines	0 comments	Download
A	media/base/filter_collection_unittest.cc	View	1 chunk	+64 lines, -0 lines	0 comments	Download
M	media/base/mock_filters.h	View	4 chunks	+6 lines, -2 lines	0 comments	Download
M	media/base/pipeline.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	media/base/pipeline.cc	View	9 chunks	+24 lines, -50 lines	0 comments	Download
M	media/base/pipeline_unittest.cc	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	media/base/video_renderer.h	View	3 chunks	+8 lines, -4 lines	0 comments	Download
M	media/filters/audio_renderer_impl.h	View	4 chunks	+3 lines, -4 lines	0 comments	Download
M	media/filters/audio_renderer_impl.cc	View	10 chunks	+11 lines, -16 lines	0 comments	Download
M	media/filters/audio_renderer_impl_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/filters/pipeline_integration_test_base.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	media/filters/pipeline_integration_test_base.cc	View	3 chunks	+16 lines, -16 lines	0 comments	Download
M	media/filters/video_renderer_base.h	View	10 chunks	+45 lines, -32 lines	0 comments	Download
M	media/filters/video_renderer_base.cc	View	13 chunks	+203 lines, -102 lines	0 comments	Download
M	media/filters/video_renderer_base_unittest.cc	View	11 chunks	+34 lines, -30 lines	0 comments	Download
M	media/media.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	media/tools/player_x11/player_x11.cc	View	3 chunks	+13 lines, -9 lines	0 comments	Download
M	webkit/media/webmediaplayer_impl.cc	View	2 chunks	+16 lines, -11 lines	0 comments	Download
M	webkit/media/webmediaplayer_proxy.h	View	2 chunks	+10 lines, -4 lines	0 comments	Download
M	webkit/media/webmediaplayer_proxy.cc	View	4 chunks	+16 lines, -11 lines	0 comments	Download