Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: utils/pub/io.dart

Issue 12262056: Clean up some warnings and deprecated calls. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/pub/git_source.dart ('k') | utils/pub/log.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/io.dart
diff --git a/utils/pub/io.dart b/utils/pub/io.dart
index c439384f4f90f5f0a682cea05e4036b886b5e548..c4f5edfa31c478a7bb09dc05b09c127974217a01 100644
--- a/utils/pub/io.dart
+++ b/utils/pub/io.dart
@@ -187,7 +187,7 @@ Future<List<String>> listDir(dir,
// aren't guaranteed to be called in a certain order. So far, they seem to.
if (done) {
log.fine("Listed directory ${dir.path}:\n"
- "${Strings.join(contents, '\n')}");
+ "${contents.join('\n')}");
completer.complete(contents);
}
};
@@ -681,7 +681,7 @@ Future _doProcess(Function fn, String executable, List<String> args, workingDir,
Future timeout(Future input, int milliseconds, String description) {
bool completed = false;
var completer = new Completer();
- var timer = new Timer(new Duration(milliseconds: milliseconds), () {
+ var timer = new Timer(new Duration(milliseconds: milliseconds), (_) {
completed = true;
completer.completeError(new TimeoutException(
'Timed out while $description.'));
@@ -770,8 +770,8 @@ Future<bool> _extractTarGzWindows(Stream<List<int>> stream,
}).then((result) {
if (result.exitCode != 0) {
throw 'Could not un-gzip (exit code ${result.exitCode}). Error:\n'
- '${Strings.join(result.stdout, "\n")}\n'
- '${Strings.join(result.stderr, "\n")}';
+ '${result.stdout.join("\n")}\n'
+ '${result.stderr.join("\n")}';
}
// Find the tar file we just created since we don't know its name.
return listDir(tempDir);
@@ -791,8 +791,8 @@ Future<bool> _extractTarGzWindows(Stream<List<int>> stream,
}).then((result) {
if (result.exitCode != 0) {
throw 'Could not un-tar (exit code ${result.exitCode}). Error:\n'
- '${Strings.join(result.stdout, "\n")}\n'
- '${Strings.join(result.stderr, "\n")}';
+ '${result.stdout.join("\n")}\n'
+ '${result.stderr.join("\n")}';
}
return true;
});
« no previous file with comments | « utils/pub/git_source.dart ('k') | utils/pub/log.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698