Clean up some warnings and deprecated calls.

utils/pub/io.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Helper functionality to make working with IO easier.
 library io;
 
 import 'dart:async';
 import 'dart:io';
 import 'dart:isolate';
@@ skipping 169 matching lines @@
     listedDirectories.add(resolvedPath);
 
     log.io("Listing directory ${dir.path}.");
     var lister = dir.list();
 
     lister.onDone = (done) {
       // TODO(rnystrom): May need to sort here if it turns out onDir and onFile
       // aren't guaranteed to be called in a certain order. So far, they seem to.
       if (done) {
         log.fine("Listed directory ${dir.path}:\n"
-                  "${Strings.join(contents, '\n')}");
+                  "${contents.join('\n')}");
         completer.complete(contents);
       }
     };
 
     // TODO(nweiz): remove this when issue 4061 is fixed.
     var stackTrace;
     try {
       throw "";
     } catch (_, localStackTrace) {
       stackTrace = localStackTrace;
@@ skipping 473 matching lines @@
 /// [milliseconds] have passed, then the return value completes in the same way.
 /// However, if [milliseconds] pass before [input] has completed, it completes
 /// with a [TimeoutException] with [description] (which should be a fragment
 /// describing the action that timed out).
 ///
 /// Note that timing out will not cancel the asynchronous operation behind
 /// [input].
 Future timeout(Future input, int milliseconds, String description) {
   bool completed = false;
   var completer = new Completer();
-  var timer = new Timer(new Duration(milliseconds: milliseconds), () {
+  var timer = new Timer(new Duration(milliseconds: milliseconds), (_) {
     completed = true;
     completer.completeError(new TimeoutException(
         'Timed out while $description.'));
   });
   input.then((value) {
     if (completed) return;
     timer.cancel();
     completer.complete(value);
   }).catchError((e) {
     if (completed) return;
@@ skipping 68 matching lines @@
     // Write the archive to a temp file.
     return createFileFromStream(stream, join(tempDir, 'data.tar.gz')).then((_) {
       // 7zip can't unarchive from gzip -> tar -> destination all in one step
       // first we un-gzip it to a tar file.
       // Note: Setting the working directory instead of passing in a full file
       // path because 7zip says "A full path is not allowed here."
       return runProcess(command, ['e', 'data.tar.gz'], workingDir: tempDir);
     }).then((result) {
       if (result.exitCode != 0) {
         throw 'Could not un-gzip (exit code ${result.exitCode}). Error:\n'
-            '${Strings.join(result.stdout, "\n")}\n'
-            '${Strings.join(result.stderr, "\n")}';
+            '${result.stdout.join("\n")}\n'
+            '${result.stderr.join("\n")}';
       }
       // Find the tar file we just created since we don't know its name.
       return listDir(tempDir);
     }).then((files) {
       var tarFile;
       for (var file in files) {
         if (path.extension(file) == '.tar') {
           tarFile = file;
           break;
         }
       }
 
       if (tarFile == null) throw 'The gzip file did not contain a tar file.';
 
       // Untar the archive into the destination directory.
       return runProcess(command, ['x', tarFile], workingDir: destination);
     }).then((result) {
       if (result.exitCode != 0) {
         throw 'Could not un-tar (exit code ${result.exitCode}). Error:\n'
-            '${Strings.join(result.stdout, "\n")}\n'
-            '${Strings.join(result.stderr, "\n")}';
+            '${result.stdout.join("\n")}\n'
+            '${result.stderr.join("\n")}';
       }
       return true;
     });
   });
 }
 
 /// Create a .tar.gz archive from a list of entries. Each entry can be a
 /// [String], [Directory], or [File] object. The root of the archive is
 /// considered to be [baseDir], which defaults to the current working directory.
 /// Returns a [ByteStream] that will emit the contents of the archive.
@@ skipping 114 matching lines @@
 Directory _getDirectory(entry) {
   if (entry is Directory) return entry;
   return new Directory(entry);
 }
 
 /// Gets a [Uri] for [uri], which can either already be one, or be a [String].
 Uri _getUri(uri) {
   if (uri is Uri) return uri;
   return Uri.parse(uri);
 }