Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 12262050: Send selected text and page title to pageLauncher.OnClicked. (Closed)

Created:
7 years, 10 months ago by Rune Fevang
Modified:
7 years, 10 months ago
Reviewers:
jam, Seigo Nonaka
CC:
chromium-reviews, yusukes+watch_chromium.org, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Send selected text and page title to pageLauncher.OnClicked. To get to the selected text from the browser side, a method GetSelectedText() was added to RenderWidgetHostView. BUG=125307 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183352

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M chrome/browser/ui/toolbar/action_box_button_controller.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M content/public/browser/render_widget_host_view.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Rune Fevang
jam: I'm not sure if this is the right way to get to the selected ...
7 years, 10 months ago (2013-02-14 21:36:15 UTC) #1
jam
On 2013/02/14 21:36:15, Rune Fevang wrote: > jam: I'm not sure if this is the ...
7 years, 10 months ago (2013-02-15 19:02:36 UTC) #2
Rune Fevang
+peng who originally introduced selection_text_ and +nona who did some work on it on windows. ...
7 years, 10 months ago (2013-02-15 20:00:53 UTC) #3
Seigo Nonaka
lgtm Seems no problem.
7 years, 10 months ago (2013-02-18 04:51:31 UTC) #4
jam
lgtm
7 years, 10 months ago (2013-02-19 16:18:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rfevang@chromium.org/12262050/1
7 years, 10 months ago (2013-02-19 19:10:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rfevang@chromium.org/12262050/1
7 years, 10 months ago (2013-02-20 00:43:52 UTC) #7
commit-bot: I haz the power
7 years, 10 months ago (2013-02-20 01:06:15 UTC) #8
Message was sent while issue was closed.
Change committed as 183352

Powered by Google App Engine
This is Rietveld 408576698