tools/dom/templates/html/impl/impl_Element.darttemplate - Issue 12262037: Make List.skip, List.take and List.reversed return Iterables, not Lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/templates/html/impl/impl_Element.darttemplate

Issue 12262037: Make List.skip, List.take and List.reversed return Iterables, not Lists. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments, small fixes. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/dom/templates/html/impl/impl_Element.darttemplate

diff --git a/tools/dom/templates/html/impl/impl_Element.darttemplate b/tools/dom/templates/html/impl/impl_Element.darttemplate

index 5499b22cfaa3c634021f5f0c715f72b505882a14..eda0836079da41826aa4fb93b2d0f670e588ea60 100644

--- a/tools/dom/templates/html/impl/impl_Element.darttemplate

+++ b/tools/dom/templates/html/impl/impl_Element.darttemplate

@@ -145,7 +145,7 @@ class _ChildrenElementList implements List {

}

- List<Element> get reversed {

+ Iterable<Element> get reversed {

return IterableMixinWorkaround.reversedList(this);

}

@@ -379,7 +379,7 @@ class _FrozenElementList implements List {

throw new UnsupportedError('');

}

- List<Element> get reversed {

+ Iterable<Element> get reversed {

return IterableMixinWorkaround.reversedList(this);

}

« no previous file with comments | « tests/corelib/list_reversed_test.dart ('k') | tools/dom/templates/html/impl/impl_Node.darttemplate » ('j') | no next file with comments »