sdk/lib/html/html_common/filtered_element_list.dart - Issue 12262037: Make List.skip, List.take and List.reversed return Iterables, not Lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/html_common/filtered_element_list.dart

Issue 12262037: Make List.skip, List.take and List.reversed return Iterables, not Lists. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments, small fixes. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/html/html_common/filtered_element_list.dart

diff --git a/sdk/lib/html/html_common/filtered_element_list.dart b/sdk/lib/html/html_common/filtered_element_list.dart

index 330b0dff7ac2142a572cf57b00322012437d369a..9820f1ac85cc2b23606c4a5cc8286bb42fd8cb73 100644

--- a/sdk/lib/html/html_common/filtered_element_list.dart

+++ b/sdk/lib/html/html_common/filtered_element_list.dart

@@ -69,7 +69,7 @@ class FilteredElementList implements List {

return element is Element && _childNodes.contains(element);

}

- List<Element> get reversed => _filtered.reversed;

+ Iterable<Element> get reversed => _filtered.reversed;

void sort([int compare(Element a, Element b)]) {

throw new UnsupportedError('TODO(jacobr): should we impl?');

« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | sdk/lib/svg/dart2js/svg_dart2js.dart » ('j') | no next file with comments »