sdk/lib/_internal/compiler/implementation/lib/js_array.dart - Issue 12262037: Make List.skip, List.take and List.reversed return Iterables, not Lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/js_array.dart

Issue 12262037: Make List.skip, List.take and List.reversed return Iterables, not Lists. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments, small fixes. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/compiler/implementation/lib/js_array.dart

diff --git a/sdk/lib/_internal/compiler/implementation/lib/js_array.dart b/sdk/lib/_internal/compiler/implementation/lib/js_array.dart

index e33ae3f6b8eac2ebf6f8fc63d8166f8062303044..91a6782fd96f3eaf8d5eb48e7fc76b80ae8595f8 100644

--- a/sdk/lib/_internal/compiler/implementation/lib/js_array.dart

+++ b/sdk/lib/_internal/compiler/implementation/lib/js_array.dart

@@ -230,7 +230,7 @@ class JSArray<E> implements List<E> {

bool every(bool f(E element)) => IterableMixinWorkaround.every(this, f);

- List<E> get reversed => IterableMixinWorkaround.reversedList(this);

+ Iterable<E> get reversed => IterableMixinWorkaround.reversedList(this);

void sort([int compare(E a, E b)]) {

checkMutable(this, 'sort');

« no previous file with comments | « sdk/lib/_collection_dev/list.dart ('k') | sdk/lib/collection/collections.dart » ('j') | no next file with comments »