Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Side by Side Diff: sdk/lib/svg/dartium/svg_dartium.dart

Issue 12262037: Make List.skip, List.take and List.reversed return Iterables, not Lists. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments, small fixes. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sdk/lib/svg/dart2js/svg_dart2js.dart ('k') | tests/corelib/iterable_skip_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 library dart.dom.svg; 1 library dart.dom.svg;
2 2
3 import 'dart:async'; 3 import 'dart:async';
4 import 'dart:collection'; 4 import 'dart:collection';
5 import 'dart:html'; 5 import 'dart:html';
6 import 'dart:html_common'; 6 import 'dart:html_common';
7 import 'dart:nativewrappers'; 7 import 'dart:nativewrappers';
8 // DO NOT EDIT 8 // DO NOT EDIT
9 // Auto-generated dart:svg library. 9 // Auto-generated dart:svg library.
10 10
(...skipping 3395 matching lines...) Expand 10 before | Expand all | Expand 10 after
3406 throw new UnsupportedError("Cannot add to immutable List."); 3406 throw new UnsupportedError("Cannot add to immutable List.");
3407 } 3407 }
3408 3408
3409 // From List<Length>: 3409 // From List<Length>:
3410 void set length(int value) { 3410 void set length(int value) {
3411 throw new UnsupportedError("Cannot resize immutable List."); 3411 throw new UnsupportedError("Cannot resize immutable List.");
3412 } 3412 }
3413 3413
3414 // clear() defined by IDL. 3414 // clear() defined by IDL.
3415 3415
3416 List<Length> get reversed { 3416 Iterable<Length> get reversed {
3417 return IterableMixinWorkaround.reversedList(this); 3417 return IterableMixinWorkaround.reversedList(this);
3418 } 3418 }
3419 3419
3420 void sort([int compare(Length a, Length b)]) { 3420 void sort([int compare(Length a, Length b)]) {
3421 throw new UnsupportedError("Cannot sort immutable List."); 3421 throw new UnsupportedError("Cannot sort immutable List.");
3422 } 3422 }
3423 3423
3424 int indexOf(Length element, [int start = 0]) => 3424 int indexOf(Length element, [int start = 0]) =>
3425 Lists.indexOf(this, element, start, this.length); 3425 Lists.indexOf(this, element, start, this.length);
3426 3426
(...skipping 683 matching lines...) Expand 10 before | Expand all | Expand 10 after
4110 throw new UnsupportedError("Cannot add to immutable List."); 4110 throw new UnsupportedError("Cannot add to immutable List.");
4111 } 4111 }
4112 4112
4113 // From List<Number>: 4113 // From List<Number>:
4114 void set length(int value) { 4114 void set length(int value) {
4115 throw new UnsupportedError("Cannot resize immutable List."); 4115 throw new UnsupportedError("Cannot resize immutable List.");
4116 } 4116 }
4117 4117
4118 // clear() defined by IDL. 4118 // clear() defined by IDL.
4119 4119
4120 List<Number> get reversed { 4120 Iterable<Number> get reversed {
4121 return IterableMixinWorkaround.reversedList(this); 4121 return IterableMixinWorkaround.reversedList(this);
4122 } 4122 }
4123 4123
4124 void sort([int compare(Number a, Number b)]) { 4124 void sort([int compare(Number a, Number b)]) {
4125 throw new UnsupportedError("Cannot sort immutable List."); 4125 throw new UnsupportedError("Cannot sort immutable List.");
4126 } 4126 }
4127 4127
4128 int indexOf(Number element, [int start = 0]) => 4128 int indexOf(Number element, [int start = 0]) =>
4129 Lists.indexOf(this, element, start, this.length); 4129 Lists.indexOf(this, element, start, this.length);
4130 4130
(...skipping 1159 matching lines...) Expand 10 before | Expand all | Expand 10 after
5290 throw new UnsupportedError("Cannot add to immutable List."); 5290 throw new UnsupportedError("Cannot add to immutable List.");
5291 } 5291 }
5292 5292
5293 // From List<PathSeg>: 5293 // From List<PathSeg>:
5294 void set length(int value) { 5294 void set length(int value) {
5295 throw new UnsupportedError("Cannot resize immutable List."); 5295 throw new UnsupportedError("Cannot resize immutable List.");
5296 } 5296 }
5297 5297
5298 // clear() defined by IDL. 5298 // clear() defined by IDL.
5299 5299
5300 List<PathSeg> get reversed { 5300 Iterable<PathSeg> get reversed {
5301 return IterableMixinWorkaround.reversedList(this); 5301 return IterableMixinWorkaround.reversedList(this);
5302 } 5302 }
5303 5303
5304 void sort([int compare(PathSeg a, PathSeg b)]) { 5304 void sort([int compare(PathSeg a, PathSeg b)]) {
5305 throw new UnsupportedError("Cannot sort immutable List."); 5305 throw new UnsupportedError("Cannot sort immutable List.");
5306 } 5306 }
5307 5307
5308 int indexOf(PathSeg element, [int start = 0]) => 5308 int indexOf(PathSeg element, [int start = 0]) =>
5309 Lists.indexOf(this, element, start, this.length); 5309 Lists.indexOf(this, element, start, this.length);
5310 5310
(...skipping 964 matching lines...) Expand 10 before | Expand all | Expand 10 after
6275 throw new UnsupportedError("Cannot add to immutable List."); 6275 throw new UnsupportedError("Cannot add to immutable List.");
6276 } 6276 }
6277 6277
6278 // From List<String>: 6278 // From List<String>:
6279 void set length(int value) { 6279 void set length(int value) {
6280 throw new UnsupportedError("Cannot resize immutable List."); 6280 throw new UnsupportedError("Cannot resize immutable List.");
6281 } 6281 }
6282 6282
6283 // clear() defined by IDL. 6283 // clear() defined by IDL.
6284 6284
6285 List<String> get reversed { 6285 Iterable<String> get reversed {
6286 return IterableMixinWorkaround.reversedList(this); 6286 return IterableMixinWorkaround.reversedList(this);
6287 } 6287 }
6288 6288
6289 void sort([int compare(String a, String b)]) { 6289 void sort([int compare(String a, String b)]) {
6290 throw new UnsupportedError("Cannot sort immutable List."); 6290 throw new UnsupportedError("Cannot sort immutable List.");
6291 } 6291 }
6292 6292
6293 int indexOf(String element, [int start = 0]) => 6293 int indexOf(String element, [int start = 0]) =>
6294 Lists.indexOf(this, element, start, this.length); 6294 Lists.indexOf(this, element, start, this.length);
6295 6295
(...skipping 1234 matching lines...) Expand 10 before | Expand all | Expand 10 after
7530 throw new UnsupportedError("Cannot add to immutable List."); 7530 throw new UnsupportedError("Cannot add to immutable List.");
7531 } 7531 }
7532 7532
7533 // From List<Transform>: 7533 // From List<Transform>:
7534 void set length(int value) { 7534 void set length(int value) {
7535 throw new UnsupportedError("Cannot resize immutable List."); 7535 throw new UnsupportedError("Cannot resize immutable List.");
7536 } 7536 }
7537 7537
7538 // clear() defined by IDL. 7538 // clear() defined by IDL.
7539 7539
7540 List<Transform> get reversed { 7540 Iterable<Transform> get reversed {
7541 return IterableMixinWorkaround.reversedList(this); 7541 return IterableMixinWorkaround.reversedList(this);
7542 } 7542 }
7543 7543
7544 void sort([int compare(Transform a, Transform b)]) { 7544 void sort([int compare(Transform a, Transform b)]) {
7545 throw new UnsupportedError("Cannot sort immutable List."); 7545 throw new UnsupportedError("Cannot sort immutable List.");
7546 } 7546 }
7547 7547
7548 int indexOf(Transform element, [int start = 0]) => 7548 int indexOf(Transform element, [int start = 0]) =>
7549 Lists.indexOf(this, element, start, this.length); 7549 Lists.indexOf(this, element, start, this.length);
7550 7550
(...skipping 555 matching lines...) Expand 10 before | Expand all | Expand 10 after
8106 8106
8107 // From List<ElementInstance>: 8107 // From List<ElementInstance>:
8108 void set length(int value) { 8108 void set length(int value) {
8109 throw new UnsupportedError("Cannot resize immutable List."); 8109 throw new UnsupportedError("Cannot resize immutable List.");
8110 } 8110 }
8111 8111
8112 void clear() { 8112 void clear() {
8113 throw new UnsupportedError("Cannot clear immutable List."); 8113 throw new UnsupportedError("Cannot clear immutable List.");
8114 } 8114 }
8115 8115
8116 List<ElementInstance> get reversed { 8116 Iterable<ElementInstance> get reversed {
8117 return IterableMixinWorkaround.reversedList(this); 8117 return IterableMixinWorkaround.reversedList(this);
8118 } 8118 }
8119 8119
8120 void sort([int compare(ElementInstance a, ElementInstance b)]) { 8120 void sort([int compare(ElementInstance a, ElementInstance b)]) {
8121 throw new UnsupportedError("Cannot sort immutable List."); 8121 throw new UnsupportedError("Cannot sort immutable List.");
8122 } 8122 }
8123 8123
8124 int indexOf(ElementInstance element, [int start = 0]) => 8124 int indexOf(ElementInstance element, [int start = 0]) =>
8125 Lists.indexOf(this, element, start, this.length); 8125 Lists.indexOf(this, element, start, this.length);
8126 8126
(...skipping 562 matching lines...) Expand 10 before | Expand all | Expand 10 after
8689 @DocsEditable 8689 @DocsEditable
8690 @DomName('SVGVKernElement') 8690 @DomName('SVGVKernElement')
8691 class _SVGVKernElement extends SvgElement { 8691 class _SVGVKernElement extends SvgElement {
8692 _SVGVKernElement.internal() : super.internal(); 8692 _SVGVKernElement.internal() : super.internal();
8693 8693
8694 @DomName('SVGVKernElement.SVGVKernElement') 8694 @DomName('SVGVKernElement.SVGVKernElement')
8695 @DocsEditable 8695 @DocsEditable
8696 factory _SVGVKernElement() => _SvgElementFactoryProvider.createSvgElement_tag( "vkern"); 8696 factory _SVGVKernElement() => _SvgElementFactoryProvider.createSvgElement_tag( "vkern");
8697 8697
8698 } 8698 }
OLDNEW
« no previous file with comments | « sdk/lib/svg/dart2js/svg_dart2js.dart ('k') | tests/corelib/iterable_skip_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698