Revert of bindings: Makes almost all attributes accessor-type properties.

Source/bindings/templates/attributes.cpp

 {% from 'conversions.cpp' import declare_enum_validation_variable, v8_value_to_local_cpp_value %}
 
 
 {##############################################################################}
 {% macro attribute_getter(attribute, world_suffix) %}
 {% filter conditional(attribute.conditional_string) %}
 static void {{attribute.name}}AttributeGetter{{world_suffix}}(
-{%- if attribute.is_data_type_property %}
+{%- if attribute.is_expose_js_accessors %}
+const v8::FunctionCallbackInfo<v8::Value>& info
+{%- else %}
 const v8::PropertyCallbackInfo<v8::Value>& info
-{%- else %}
-const v8::FunctionCallbackInfo<v8::Value>& info
 {%- endif %})
 {
     {% if attribute.is_reflect and not attribute.is_url
           and attribute.idl_type == 'DOMString' and is_node
           and not attribute.is_implemented_in_private_script %}
     {% set cpp_class, v8_class = 'Element', 'V8Element' %}
     {% endif %}
     {# holder #}
     {% if not attribute.is_static %}
     {% if attribute.is_lenient_this %}
@@ skipping 26 matching lines @@
     {% endif %}
     {# Local variables #}
     {% if attribute.is_call_with_execution_context %}
     ExecutionContext* executionContext = currentExecutionContext(info.GetIsolate());
     {% endif %}
     {% if attribute.is_call_with_script_state %}
     ScriptState* scriptState = ScriptState::current(info.GetIsolate());
     {% endif %}
     {% if ((attribute.is_check_security_for_frame or
             attribute.is_check_security_for_window) and
-           not attribute.is_data_type_property) or
+           attribute.is_expose_js_accessors) or
           attribute.is_check_security_for_node or
           attribute.is_getter_raises_exception %}
     ExceptionState exceptionState(ExceptionState::GetterContext, "{{attribute.name}}", "{{interface_name}}", holder, info.GetIsolate());
     {% endif %}
     {% if attribute.is_explicit_nullable %}
     bool isNull = false;
     {% endif %}
     {% if attribute.is_implemented_in_private_script %}
     {{attribute.cpp_type}} result{{attribute.cpp_type_initializer}};
     if (!{{attribute.cpp_value_original}})
         return;
     {% elif attribute.cpp_value_original %}
     {{attribute.cpp_type}} {{attribute.cpp_value}}({{attribute.cpp_value_original}});
     {% endif %}
     {# Checks #}
     {% if attribute.is_getter_raises_exception %}
     if (UNLIKELY(exceptionState.throwIfNeeded()))
         return;
     {% endif %}
     {# Security checks #}
-    {% if not attribute.is_data_type_property %}
+    {% if attribute.is_expose_js_accessors %}
     {% if attribute.is_check_security_for_window %}
     if (LocalDOMWindow* window = impl->toDOMWindow()) {
         if (!BindingSecurity::shouldAllowAccessToFrame(info.GetIsolate(), window->frame(), exceptionState)) {
             v8SetReturnValueNull(info);
             exceptionState.throwIfNeeded();
             return;
         }
         if (!window->document())
             return;
     }
@@ skipping 43 matching lines @@
     {% if attribute.use_output_parameter_for_result %}
     {{attribute.cpp_type}} result;
     {{attribute.cpp_value}};
     {% endif %}
     {{attribute.v8_set_return_value}};
     {% endif %}
 }
 {% endfilter %}
 {% endmacro %}
 
-
 {######################################}
 {% macro release_only_check(reflect_only_values, reflect_missing,
                             reflect_invalid, reflect_empty, cpp_value) %}
 {# Attribute is limited to only known values: check that the attribute value is
    one of those. If not, set it to the empty string.
    http://www.whatwg.org/specs/web-apps/current-work/#limited-to-only-known-values #}
 {% if reflect_empty %}
 if ({{cpp_value}}.isNull()) {
 {% if reflect_missing %}
     {{cpp_value}} = "{{reflect_missing}}";
@@ skipping 18 matching lines @@
 } else {
     {{cpp_value}} = "{{reflect_invalid}}";
 }
 {% endmacro %}
 
 
 {##############################################################################}
 {% macro attribute_getter_callback(attribute, world_suffix) %}
 {% filter conditional(attribute.conditional_string) %}
 static void {{attribute.name}}AttributeGetterCallback{{world_suffix}}(
-{%- if attribute.is_data_type_property %}
+{%- if attribute.is_expose_js_accessors %}
+const v8::FunctionCallbackInfo<v8::Value>& info
+{%- else %}
 v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>& info
-{%- else %}
-const v8::FunctionCallbackInfo<v8::Value>& info
 {%- endif %})
 {
     TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMGetter");
     {% if attribute.deprecate_as %}
     UseCounter::countDeprecationIfNotPrivateScript(info.GetIsolate(), callingExecutionContext(info.GetIsolate()), UseCounter::{{attribute.deprecate_as}});
     {% endif %}
     {% if attribute.measure_as %}
     UseCounter::countIfNotPrivateScript(info.GetIsolate(), callingExecutionContext(info.GetIsolate()), UseCounter::{{attribute.measure_as('AttributeGetter')}});
     {% endif %}
     {% if world_suffix in attribute.activity_logging_world_list_for_getter %}
@@ skipping 13 matching lines @@
     {% endif %}
     TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
 }
 {% endfilter %}
 {% endmacro %}
 
 
 {##############################################################################}
 {% macro constructor_getter_callback(attribute, world_suffix) %}
 {% filter conditional(attribute.conditional_string) %}
-static void {{attribute.name}}ConstructorGetterCallback{{world_suffix}}(v8::Local<v8::Name> property, const v8::PropertyCallbackInfo<v8::Value>& info)
+static void {{attribute.name}}ConstructorGetterCallback{{world_suffix}}(
+{%- if attribute.is_expose_js_accessors %}
+const v8::FunctionCallbackInfo<v8::Value>& info
+{%- else %}
+v8::Local<v8::Name> property, const v8::PropertyCallbackInfo<v8::Value>& info
+{%- endif %})
 {
     TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMGetter");
     {% if attribute.deprecate_as %}
     UseCounter::countDeprecationIfNotPrivateScript(info.GetIsolate(), callingExecutionContext(info.GetIsolate()), UseCounter::{{attribute.deprecate_as}});
     {% endif %}
     {% if attribute.measure_as %}
     UseCounter::countIfNotPrivateScript(info.GetIsolate(), callingExecutionContext(info.GetIsolate()), UseCounter::{{attribute.measure_as('ConstructorGetter')}});
     {% endif %}
     v8ConstructorAttributeGetter(property, info);
     TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
 }
 {% endfilter %}
 {% endmacro %}
 
 
 {##############################################################################}
 {% macro attribute_setter(attribute, world_suffix) %}
 {% filter conditional(attribute.conditional_string) %}
 static void {{attribute.name}}AttributeSetter{{world_suffix}}(
-{%- if attribute.is_data_type_property %}
+{%- if attribute.is_expose_js_accessors %}
+v8::Local<v8::Value> v8Value, const v8::FunctionCallbackInfo<v8::Value>& info
+{%- else %}
 v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<void>& info
-{%- else %}
-v8::Local<v8::Value> v8Value, const v8::FunctionCallbackInfo<v8::Value>& info
 {%- endif %})
 {
     {% if attribute.is_reflect and attribute.idl_type == 'DOMString'
           and is_node and not attribute.is_implemented_in_private_script %}
     {% set cpp_class, v8_class = 'Element', 'V8Element' %}
     {% endif %}
     {% if attribute.has_setter_exception_state or
           ((not attribute.is_replaceable and
             not attribute.constructor_type and
-            not attribute.is_data_type_property) and
+            attribute.is_expose_js_accessors) and
            (attribute.is_check_security_for_frame or
             attribute.is_check_security_for_node or
             attribute.is_check_security_for_window)) %}
     {% set raise_exception = 1 %}
     {% else %}
     {% set raise_exception = 0 %}
     {% endif %}
     {# Local variables #}
     {% if (not attribute.is_static and
            not attribute.is_replaceable and
@@ skipping 27 matching lines @@
             not attribute.constructor_type %}
     {{cpp_class}}* impl = {{v8_class}}::toImpl(holder);
     {% endif %}
     {% if attribute.idl_type == 'EventHandler' and interface_name == 'Window' %}
     if (!impl->document())
         return;
     {% endif %}
     {# Security checks #}
     {% if not attribute.is_replaceable and
           not attribute.constructor_type %}
-    {% if not attribute.is_data_type_property %}
+    {% if attribute.is_expose_js_accessors %}
     {% if attribute.is_check_security_for_window %}
     if (LocalDOMWindow* window = impl->toDOMWindow()) {
         if (!BindingSecurity::shouldAllowAccessToFrame(info.GetIsolate(), window->frame(), exceptionState)) {
             v8SetReturnValue(info, v8Value);
             exceptionState.throwIfNeeded();
             return;
         }
         if (!window->document())
             return;
     }
     {% elif attribute.is_check_security_for_frame %}
     if (!BindingSecurity::shouldAllowAccessToFrame(info.GetIsolate(), impl->frame(), exceptionState)) {
         v8SetReturnValue(info, v8Value);
         exceptionState.throwIfNeeded();
         return;
     }
     {% endif %}
     {% endif %}
     {% if attribute.is_check_security_for_node %}
     if (!BindingSecurity::shouldAllowAccessToNode(info.GetIsolate(), {{attribute.cpp_value}}, exceptionState)) {
         v8SetReturnValue(info, v8Value);
         exceptionState.throwIfNeeded();
         return;
     }
     {% endif %}
-    {% endif %}{# not attribute.is_replaceable and
-                  not attribute.constructor_type #}
+    {% endif %}{# not attribute.is_replaceable #}
     {# Convert JS value to C++ value #}
     {% if attribute.idl_type != 'EventHandler' %}
     {% if v8_value_to_local_cpp_value(attribute) %}
     {{v8_value_to_local_cpp_value(attribute) | indent}}
     {% endif %}
     {% elif not is_node %}{# EventHandler hack #}
     moveEventListenerToNewWrapper(info.GetIsolate(), holder, {{attribute.event_handler_getter_expression}}, v8Value, {{v8_class}}::eventListenerCacheIndex);
     {% endif %}
     {# Type checking, possibly throw a TypeError, per:
        http://www.w3.org/TR/WebIDL/#es-type-mapping #}
@@ skipping 44 matching lines @@
     {% endif %}
 }
 {% endfilter %}
 {% endmacro %}
 
 
 {##############################################################################}
 {% macro attribute_setter_callback(attribute, world_suffix) %}
 {% filter conditional(attribute.conditional_string) %}
 static void {{attribute.name}}AttributeSetterCallback{{world_suffix}}(
-{%- if attribute.is_data_type_property %}
+{%- if attribute.is_expose_js_accessors %}
+const v8::FunctionCallbackInfo<v8::Value>& info
+{%- else %}
 v8::Local<v8::Name>, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<void>& info
-{%- else %}
-const v8::FunctionCallbackInfo<v8::Value>& info
 {%- endif %})
 {
-    {% if not attribute.is_data_type_property %}
+    {% if attribute.is_expose_js_accessors %}
     v8::Local<v8::Value> v8Value = info[0];
     {% endif %}
     TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMSetter");
     {% if attribute.deprecate_as %}
     UseCounter::countDeprecationIfNotPrivateScript(info.GetIsolate(), callingExecutionContext(info.GetIsolate()), UseCounter::{{attribute.deprecate_as}});
     {% endif %}
     {% if attribute.measure_as %}
     UseCounter::countIfNotPrivateScript(info.GetIsolate(), callingExecutionContext(info.GetIsolate()), UseCounter::{{attribute.measure_as('AttributeSetter')}});
     {% endif %}
     {% if world_suffix in attribute.activity_logging_world_list_for_setter %}
@@ skipping 99 matching lines @@
 {% set getter_callback_for_main_world =
        '%sForMainWorld' % getter_callback
        if attribute.is_per_world_bindings else '0' %}
 {% set setter_callback_for_main_world =
        '%sForMainWorld' % setter_callback
        if attribute.is_per_world_bindings and attribute.has_setter else '0' %}
 {% set wrapper_type_info =
        'const_cast<WrapperTypeInfo*>(&V8%s::wrapperTypeInfo)' %
            attribute.constructor_type
        if attribute.constructor_type else '0' %}
-{% if attribute.is_data_type_property %}
 {% set access_control = 'static_cast<v8::AccessControl>(%s)' %
                         ' | '.join(attribute.access_control_list) %}
-{% else %}
-{% set access_control = 'v8::DEFAULT' %}
-{% endif %}
 {% set property_attribute = 'static_cast<v8::PropertyAttribute>(%s)' %
                             ' | '.join(attribute.property_attributes) %}
 {% set only_exposed_to_private_script =
        'V8DOMConfiguration::OnlyExposedToPrivateScript'
        if attribute.only_exposed_to_private_script else
        'V8DOMConfiguration::ExposedToAllScripts' %}
 {% set property_location_list = [] %}
 {% if attribute.on_instance %}
 {% set property_location_list = property_location_list + ['V8DOMConfiguration::OnInstance'] %}
 {% endif %}
@@ skipping 14 matching lines @@
        setter_callback_for_main_world,
        wrapper_type_info,
        access_control,
        property_attribute,
        only_exposed_to_private_script,
        property_location,
        holder_check,
    ] %}
 {{'{'}}{{attribute_configuration_list | join(', ')}}{{'}'}}
 {%- endmacro %}