Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1226203012: Revert of bindings: Makes almost all attributes accessor-type properties. (Closed)

Created:
5 years, 5 months ago by Dirk Pranke
Modified:
5 years, 5 months ago
Reviewers:
haraken, bashi, Yuki
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Revert of bindings: Makes almost all attributes accessor-type properties. (patchset #11 id:200001 of https://codereview.chromium.org/1193793003/) Reason for revert: This causes failures in content_browsertests, e.g.: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/45398 I verified that this was the issue via 'git bisect' on linux; it should be trivial to reproduce. Sorry! Original issue's description: > bindings: Makes almost all attributes accessor-type properties. > > Introduces |attribute.is_data_type_property| as a > template variable to specify the property type. > > is_data_type_property is true only for > - attributes of Window interface > just because we'd like to move on step by step. > We'll make Window's attributes accessor-type > in a following CL. > - constructors > which must be implemented as methods rather than > attributes. This is another task. > > is_data_type_property will be gone once we resolve > the above two cases. > > Note that we need an undesired hack in {HTML,XML}Document.idl > because v8::Template::SetAccessorProperty doesn't support > inheriting accessors on InstanceTemplate. > > BUG=43394, 491006 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198687 TBR=haraken@chromium.org,bashi@chromium.org,yukishiino@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=43394, 491006 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198698

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+498 lines, -531 lines) Patch
M LayoutTests/http/tests/dom/location-stringify.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xss-DENIED-assign-location-href-javascript-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/v8_attributes.py View 4 chunks +40 lines, -8 lines 0 comments Download
M Source/bindings/scripts/v8_interface.py View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/bindings/scripts/v8_utilities.py View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/bindings/templates/attributes.cpp View 12 chunks +24 lines, -25 lines 0 comments Download
M Source/bindings/templates/interface.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/bindings/templates/interface_base.cpp View 4 chunks +27 lines, -20 lines 0 comments Download
M Source/bindings/tests/results/core/V8SVGTestInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestException.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 18 chunks +77 lines, -80 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceAccessors.cpp View 4 chunks +21 lines, -10 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceNode.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceOwnProperties.cpp View 6 chunks +26 lines, -16 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceOwnPropertiesDerived.cpp View 6 chunks +26 lines, -16 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp View 4 chunks +17 lines, -9 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestNode.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 8 chunks +185 lines, -188 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestTypedefs.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterface5.cpp View 5 chunks +14 lines, -15 lines 0 comments Download
M Source/core/dom/Document.idl View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/dom/XMLDocument.idl View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/html/HTMLDocument.idl View 1 chunk +0 lines, -8 lines 0 comments Download
D Source/modules/cachestorage/CompositorWorkerCacheStorage.idl View 1 chunk +0 lines, -17 lines 0 comments Download
D Source/modules/cachestorage/DedicatedWorkerCacheStorage.idl View 1 chunk +0 lines, -17 lines 0 comments Download
D Source/modules/cachestorage/ServiceWorkerCacheStorage.idl View 1 chunk +0 lines, -17 lines 0 comments Download
D Source/modules/cachestorage/SharedWorkerCacheStorage.idl View 1 chunk +0 lines, -17 lines 0 comments Download
M Source/modules/cachestorage/WorkerCacheStorage.idl View 1 chunk +1 line, -7 lines 0 comments Download
M Source/modules/modules.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Dirk Pranke
Created Revert of bindings: Makes almost all attributes accessor-type properties.
5 years, 5 months ago (2015-07-10 17:09:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226203012/1
5 years, 5 months ago (2015-07-10 17:09:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=198698
5 years, 5 months ago (2015-07-10 17:10:11 UTC) #3
haraken
LGTM, thanks for the revert!
5 years, 5 months ago (2015-07-11 00:46:18 UTC) #4
Yuki
5 years, 5 months ago (2015-07-13 04:17:08 UTC) #5
Message was sent while issue was closed.
On 2015/07/11 00:46:18, haraken wrote:
> LGTM, thanks for the revert!

lgtm.  Thanks!

Powered by Google App Engine
This is Rietveld 408576698