Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1226203011: Remove unused byte from Map::instance_sizes field. (Closed)

Created:
5 years, 5 months ago by Michael Starzinger
Modified:
5 years, 5 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove unused byte from Map::instance_sizes field. Note that there are currently no objects that require a pre-allocated properties backing store, all such slots are in-object properties from the begining. Hence {unused + pre_allocated - inobject == 0} holds. R=verwaest@chromium.org Committed: https://crrev.com/2027335f1ce44b0c6523eb5e55881e2a4e162815 Cr-Commit-Position: refs/heads/master@{#29590}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Minor cleanup. #

Patch Set 3 : Addressed comment. #

Patch Set 4 : Ported to all architectures. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -907 lines) Patch
M src/arm/builtins-arm.cc View 1 2 3 3 chunks +6 lines, -80 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 2 3 1 chunk +0 lines, -20 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 2 3 3 chunks +12 lines, -56 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 2 3 1 chunk +0 lines, -20 lines 0 comments Download
M src/bailout-reason.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M src/bootstrapper.cc View 1 2 6 chunks +2 lines, -8 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/factory.cc View 4 chunks +5 lines, -9 lines 0 comments Download
M src/heap/heap.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/heap.cc View 5 chunks +5 lines, -16 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 3 chunks +6 lines, -75 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 2 3 3 chunks +5 lines, -87 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 2 3 1 chunk +0 lines, -20 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 2 3 3 chunks +7 lines, -91 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 2 3 1 chunk +0 lines, -20 lines 0 comments Download
M src/objects.h View 1 2 3 4 chunks +7 lines, -14 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-inl.h View 3 chunks +3 lines, -12 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 1 2 3 3 chunks +4 lines, -85 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 2 3 1 chunk +0 lines, -20 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/builtins-x64.cc View 1 2 3 3 chunks +6 lines, -76 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 2 3 1 chunk +0 lines, -15 lines 0 comments Download
M src/x87/builtins-x87.cc View 1 2 3 3 chunks +6 lines, -75 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 2 3 1 chunk +0 lines, -14 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 1 2 3 6 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Michael Starzinger
Architecture ports are still in the works. But the rest is ready.
5 years, 5 months ago (2015-07-10 16:04:59 UTC) #1
Toon Verwaest
Awesome! Uppercase LGTM https://codereview.chromium.org/1226203011/diff/1/src/bootstrapper.cc File src/bootstrapper.cc (right): https://codereview.chromium.org/1226203011/diff/1/src/bootstrapper.cc#newcode1302 src/bootstrapper.cc:1302: iterator_result_map->set_inobject_properties( You probably don't need this ...
5 years, 5 months ago (2015-07-10 16:15:17 UTC) #2
Michael Starzinger
https://codereview.chromium.org/1226203011/diff/1/src/bootstrapper.cc File src/bootstrapper.cc (right): https://codereview.chromium.org/1226203011/diff/1/src/bootstrapper.cc#newcode1302 src/bootstrapper.cc:1302: iterator_result_map->set_inobject_properties( On 2015/07/10 16:15:17, Toon Verwaest wrote: > You ...
5 years, 5 months ago (2015-07-10 16:21:19 UTC) #3
Toon Verwaest
lgtm
5 years, 5 months ago (2015-07-10 16:23:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226203011/60001
5 years, 5 months ago (2015-07-13 07:52:47 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 5 months ago (2015-07-13 08:26:27 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 08:26:46 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2027335f1ce44b0c6523eb5e55881e2a4e162815
Cr-Commit-Position: refs/heads/master@{#29590}

Powered by Google App Engine
This is Rietveld 408576698