Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1226203010: ppapi: VideoEncoder: augment precision of the IVF container (Closed)

Created:
5 years, 5 months ago by llandwerlin-old
Modified:
5 years, 5 months ago
Reviewers:
bbudge, binji
CC:
binji+watch_chromium.org, chromium-reviews, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ppapi: VideoEncoder: augment precision of the IVF container Use millisecond timestamps in the IVF container rather than having 1.0/30 units of time. This prevents a drift in the replay of the video because the recorder might not schedule frames at exactly 33.3333ms. BUG=503153 TEST=record a 2 minutes vp8 video using the video encoder NaCl SDK and verify the produced video last exactly 2 minutes Committed: https://crrev.com/0141e7812a6a7b6b24b7b4df25bf5d4a1bc8c348 Cr-Commit-Position: refs/heads/master@{#338694}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -10 lines) Patch
M native_client_sdk/src/examples/api/video_encode/video_encode.cc View 6 chunks +12 lines, -5 lines 0 comments Download
M ppapi/examples/video_encode/video_encode.cc View 6 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
llandwerlin-old
bbudge@, binji@: Could you review this change? This is the same change in the 2 ...
5 years, 5 months ago (2015-07-10 16:39:21 UTC) #2
bbudge
lgtm
5 years, 5 months ago (2015-07-10 16:58:21 UTC) #3
binji
lgtm
5 years, 5 months ago (2015-07-14 15:45:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226203010/1
5 years, 5 months ago (2015-07-14 15:48:36 UTC) #6
commit-bot: I haz the power
The author lionel.g.landwerlin@intel.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-14 15:48:39 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-14 15:57:41 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 15:58:31 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0141e7812a6a7b6b24b7b4df25bf5d4a1bc8c348
Cr-Commit-Position: refs/heads/master@{#338694}

Powered by Google App Engine
This is Rietveld 408576698