Componentize //chrome/browser/offline_pages

components/offline_pages/BUILD.gn

Index: components/offline_pages/BUILD.gn
diff --git a/components/offline_pages/BUILD.gn b/components/offline_pages/BUILD.gn
index 36cee8587b5b202476d5a7412bc5d7392c740aa0..c5ccc9560e8ed1e56e50d67dc9e6897105596c27 100644
--- a/components/offline_pages/BUILD.gn
+++ b/components/offline_pages/BUILD.gn
@@ -10,6 +10,8 @@ static_library("offline_pages") {
     "offline_page_item.h",
     "offline_page_metadata_store.cc",
     "offline_page_metadata_store.h",
+    "offline_page_metadata_store_impl.cc",
+    "offline_page_metadata_store_impl.h",
     "offline_page_model.cc",
     "offline_page_model.h",
   ]
@@ -17,7 +19,10 @@ static_library("offline_pages") {
   deps = [
     "//base",
     "//components/keyed_service/core",
+    "//components/leveldb_proto",
+    "//components/offline_pages/proto:offline_pages_proto",
     "//net",
+    "//third_party/leveldatabase",
     "//url",
   ]
 }
@@ -25,11 +30,13 @@ static_library("offline_pages") {
 source_set("unit_tests") {
   testonly = true
   sources = [
+    "offline_page_metadata_store_impl_unittest.cc",
     "offline_page_model_unittest.cc",
   ]
 
   deps = [
     ":offline_pages",
+    "//sync",

[fgorski, 2015/07/16 16:32:43]

Do I need this?

[Abhishek, 2015/07/17 07:50:37]

I had added it due to below error:
"gen/components/offline_pages/proto/offline_pages.pb.h:9:10: fatal error:
'google/protobuf/stubs/common.h' file not
foundgen/components/offline_pages/proto/offline_pages.pb.h:9:10: fatal error:
'google/protobuf/stubs/common.h' file not found"

But this can be solved using "//net" as well. So I'm changing it to "//net".

Please correct me if I'm wrong here!

[fgorski, 2015/07/17 17:25:00]

Did you try taking dependency on the protobuf?
"//components/offline_pages/proto:offline_pages_proto",

[Abhishek, 2015/07/20 07:24:07]

Thanks!
Done.

     "//testing/gtest",
   ]
 }