Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: chrome/chrome_browser.gypi

Issue 1226173004: Componentize //chrome/browser/offline_pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated unittest and gn build Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_browser.gypi
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi
index 6718aad3d54b02edbd320ad44ba0469c26538830..3aa0ba65e2e262f20fa63132392104d3b71bec0c 100644
--- a/chrome/chrome_browser.gypi
+++ b/chrome/chrome_browser.gypi
@@ -1358,8 +1358,6 @@
'browser/enhanced_bookmarks/bookmark_server_cluster_service_factory.h',
'browser/enhanced_bookmarks/enhanced_bookmark_model_factory.cc',
'browser/enhanced_bookmarks/enhanced_bookmark_model_factory.h',
- 'browser/offline_pages/offline_page_metadata_store_impl.cc',
- 'browser/offline_pages/offline_page_metadata_store_impl.h',
'browser/offline_pages/offline_page_mhtml_archiver.cc',
'browser/offline_pages/offline_page_mhtml_archiver.h',
],
@@ -3141,7 +3139,6 @@
'common',
'common_net',
'encrypted_cert_logger_proto',
- 'offline_pages_proto',
'probe_message_proto',
'../components/components.gyp:autofill_core_browser',
'../components/components.gyp:bookmarks_browser',
@@ -3890,18 +3887,6 @@
'includes': [ '../build/protoc.gypi', ],
},
{
- # Protobuf compiler / generator for the offline page item protocol buffer.
- # GN version: //chrome/browser/offline_pages:offline_pages_proto
- 'target_name': 'offline_pages_proto',
- 'type': 'static_library',
- 'sources': [ 'browser/offline_pages/offline_pages.proto', ],
- 'variables': {
- 'proto_in_dir': 'browser/offline_pages',
- 'proto_out_dir': 'chrome/browser/offline_pages',
- },
- 'includes': [ '../build/protoc.gypi', ],
- },
- {
# Protobuf compiler / generator for Probe Message.
# GN version: //chrome/browser/net:probe_message_proto
'target_name': 'probe_message_proto',

Powered by Google App Engine
This is Rietveld 408576698