Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: chrome/chrome_browser.gypi

Issue 1226173004: Componentize //chrome/browser/offline_pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated for android port Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/offline_pages/offline_pages.proto ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_browser.gypi
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi
index fa8c33b233a36984a745e789335fd12c43481ccd..623bde3e256f05aea7309352d448cc8fe3ad01ff 100644
--- a/chrome/chrome_browser.gypi
+++ b/chrome/chrome_browser.gypi
@@ -1356,8 +1356,6 @@
'browser/enhanced_bookmarks/bookmark_server_cluster_service_factory.h',
'browser/enhanced_bookmarks/enhanced_bookmark_model_factory.cc',
'browser/enhanced_bookmarks/enhanced_bookmark_model_factory.h',
- 'browser/offline_pages/offline_page_metadata_store_impl.cc',
- 'browser/offline_pages/offline_page_metadata_store_impl.h',
],
'chrome_browser_bookmark_android_sources': [
'browser/android/offline_pages/offline_page_bridge.cc',
@@ -3137,7 +3135,6 @@
'common',
'common_net',
'encrypted_cert_logger_proto',
- 'offline_pages_proto',
'probe_message_proto',
'../components/components.gyp:autofill_core_browser',
'../components/components.gyp:bookmarks_browser',
@@ -3896,18 +3893,6 @@
'includes': [ '../build/protoc.gypi', ],
},
{
- # Protobuf compiler / generator for the offline page item protocol buffer.
- # GN version: //chrome/browser/offline_pages:offline_pages_proto
- 'target_name': 'offline_pages_proto',
- 'type': 'static_library',
- 'sources': [ 'browser/offline_pages/offline_pages.proto', ],
- 'variables': {
- 'proto_in_dir': 'browser/offline_pages',
- 'proto_out_dir': 'chrome/browser/offline_pages',
- },
- 'includes': [ '../build/protoc.gypi', ],
- },
- {
# Protobuf compiler / generator for Probe Message.
# GN version: //chrome/browser/net:probe_message_proto
'target_name': 'probe_message_proto',
« no previous file with comments | « chrome/browser/offline_pages/offline_pages.proto ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698