Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1226163010: Fix content verifier problem with content scripts (Closed)

Created:
5 years, 5 months ago by asargent_no_longer_on_chrome
Modified:
5 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix content verifier problem with content scripts The problem is that we were creating the ContentVerifier too late in ExtensionSystemImpl::Shared::Init, after the script loader had already tried grabbing a reference to it for use on another thead. Therefore at run time, for all content scripts we were was seeing a null pointer for the content verifier and skipping verification of those scripts. BUG=509130 Committed: https://crrev.com/fe6dc62c549db502a0323ebbebab7ffd4f5cebd7 Cr-Commit-Position: refs/heads/master@{#339283}

Patch Set 1 #

Patch Set 2 : minor cleanup #

Patch Set 3 : merged latest head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -36 lines) Patch
M chrome/browser/extensions/content_verifier_browsertest.cc View 1 7 chunks +132 lines, -19 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_system_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
A chrome/test/data/extensions/content_verifier/content_script.crx View Binary file 0 comments Download
M extensions/browser/content_verifier.h View 1 chunk +7 lines, -0 lines 0 comments Download
M extensions/browser/content_verifier.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M extensions/browser/content_verify_job.cc View 2 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
asargent_no_longer_on_chrome
5 years, 5 months ago (2015-07-13 18:19:51 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226163010/40001
5 years, 5 months ago (2015-07-13 21:03:07 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-13 23:29:23 UTC) #6
asargent_no_longer_on_chrome
rockot: friendly ping
5 years, 5 months ago (2015-07-16 19:35:53 UTC) #7
Ken Rockot(use gerrit already)
lgtm
5 years, 5 months ago (2015-07-16 19:42:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226163010/40001
5 years, 5 months ago (2015-07-16 19:52:23 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/74355) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 5 months ago (2015-07-16 20:33:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226163010/40001
5 years, 5 months ago (2015-07-16 21:39:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226163010/40001
5 years, 5 months ago (2015-07-17 17:26:07 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-17 18:10:28 UTC) #18
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/fe6dc62c549db502a0323ebbebab7ffd4f5cebd7 Cr-Commit-Position: refs/heads/master@{#339283}
5 years, 5 months ago (2015-07-17 18:11:17 UTC) #19
kelvinp
5 years, 5 months ago (2015-07-18 00:07:23 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1243533005/ by kelvinp@chromium.org.

The reason for reverting is: The ContentVerifierTest.ContentScripts test
introduced in this change has been failing 
consistently on Vista. See below

http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/bui...
http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/bui....

Powered by Google App Engine
This is Rietveld 408576698