Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1226153004: ATK accessibility support for web content on Aura Linux. (Closed)

Created:
5 years, 5 months ago by Peter Lundblad
Modified:
5 years, 5 months ago
Reviewers:
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ATK accessibility support for web content on Aura Linux. Not for review. This CL adds Accessibility support to Chromium browser for linux platform. It successfully exposes an AX Tree for content. You can test this with chrome://accessibility. This is just the initial CL to get the accessibility support on Linux. Other interfaces need to be implemented to make it useful for accessibility tools. ATK_COMPONENT & ATK_VALUE Interfaces has been implemented in this CL. Content: <html> <body> <input type="checkbox"> </body> </html> AX Tree: [document web] enabled focusable focused id=1 ++[section] enabled id=4 ++++[check box] enabled focusable id=5 BUG=463671 patch from issue 1128183010 at patchset 220001 (http://crrev.com/1128183010#ps220001)

Patch Set 1 #

Patch Set 2 : Fix the GN build. #

Patch Set 3 : Add use_atk to the gn build, put atk specific sources in a separate gyp variable and reuse in gn bu… #

Patch Set 4 : Fix chromecast build by changing the ifdefs back to what they were and then adding another exclusio… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1043 lines, -68 lines) Patch
M build/config/linux/BUILD.gn View 1 1 chunk +26 lines, -0 lines 0 comments Download
M build/config/ui.gni View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/BUILD.gn View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter.cc View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
A content/browser/accessibility/accessibility_tree_formatter_auralinux.cc View 1 chunk +106 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility.h View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility.cc View 1 2 3 1 chunk +6 lines, -5 lines 0 comments Download
A content/browser/accessibility/browser_accessibility_auralinux.h View 1 chunk +92 lines, -0 lines 0 comments Download
A content/browser/accessibility/browser_accessibility_auralinux.cc View 1 chunk +672 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.h View 1 2 3 2 chunks +8 lines, -2 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.cc View 1 2 3 1 chunk +6 lines, -5 lines 0 comments Download
A + content/browser/accessibility/browser_accessibility_manager_auralinux.h View 1 chunk +19 lines, -23 lines 0 comments Download
A content/browser/accessibility/browser_accessibility_manager_auralinux.cc View 1 chunk +56 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 2 chunks +23 lines, -0 lines 0 comments Download
M ui/accessibility/BUILD.gn View 1 2 3 chunks +3 lines, -31 lines 0 comments Download
M ui/views/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (2 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226153004/60001
5 years, 5 months ago (2015-07-15 14:37:34 UTC) #2
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 15:02:58 UTC) #4
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698