Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 1226143010: Port Toggleable to the new animation system (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
mpcomplete, Matt Perry
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : boogs #

Patch Set 3 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -20 lines) Patch
M sky/sdk/lib/widgets/checkbox.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M sky/sdk/lib/widgets/switch.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/toggleable.dart View 1 2 3 chunks +20 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 5 months ago (2015-07-09 22:22:18 UTC) #1
Matt Perry
lgtm
5 years, 5 months ago (2015-07-09 22:33:43 UTC) #3
abarth-chromium
5 years, 5 months ago (2015-07-09 22:47:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
3f32a283324b52f56403f9cbc9506e9bf26b8501 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698